GNOME Bugzilla – Bug 688331
Extensions don't reactivate after lock-screen
Last modified: 2013-11-25 07:21:14 UTC
Whenever I lock the screen the extensions stay deactivated. I cannot reactivate them through the web interface or the Tweak Tool. Trying to update (thus re-install) one of them actually removed it. Although that issue might me unrelated. Here is a list of the extensions I have currently installed: alternative-status-menu@sam.sambull.org disable-window-animations@github.com maximus@mathematical.coffee.gmail.com nohotcorner@azuri.free.fr removeaccesibility@lomegor window_buttons@biox.github.com window-options@mathematical.coffee.gmail.com windowsNavigator@gnome-shell-extensions.gcampax.github.com
Created attachment 258037 [details] Before lock screen is active
I have the very same problem on gnome 3.10.0 and 3.10.1 (under Fedora F-20 alpha). Restarting gnome-shell (ALT+F2 then r) makes the extensions reappear. However only a few extentions are affected, e.g. Places Status Indicator, Messaging Menu,.. The weather extension is unaffected. See screenshots.
Created attachment 258038 [details] After the lock screen was active
Same on my Arch Linux with Gnome 3.10, extensions like Activities-Configurator, Places and Taskbar are gone and can be brought back by Alt-F2 -> r .
Created attachment 258117 [details] [review] catch more errors on extensions enable() and disable() it's due to errors on faulty extensions
Review of attachment 258117 [details] [review]: ::: js/ui/extensionSystem.js @@ +125,3 @@ + extension.stateObj.enable(); + } catch(e) { + logExtensionError(uuid, e); Should we really mark the extension as ENABLED in this case?
Review of attachment 258117 [details] [review]: Right. logExtensionError will set the extension's state to ERROR, which means "don't touch it after". You need to return there, and put the disabling/re-enabling of other extensions in a finally block so that it always runs. You can also remove the logExtensionError wrappers around disableExtension / enableExtension below.
Created attachment 258145 [details] [review] patch v2
Review of attachment 258145 [details] [review]: Looks good to me.
Pushed on slaf's behalf.