After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687977 - icon-theme: Add some preconditions for NULL arguments
icon-theme: Add some preconditions for NULL arguments
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-11-09 10:59 UTC by Stef Walter
Modified: 2012-11-09 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon-theme: Add some preconditions for NULL arguments (1.44 KB, patch)
2012-11-09 10:59 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-11-09 10:59:08 UTC 
gtk_icon_info_load_symbolic(), gtk_icon_info_load_symbolic_for_context(),
gtk_icon_info_load_symbolic_for_style() have no checks to see whether input
is NULL. 

Add precondition checks for consistency.
Comment 1 Stef Walter 2012-11-09 10:59:14 UTC 
Created attachment 228544 [details] [review]
icon-theme: Add some preconditions for NULL arguments

Related to this crash: https://bugzilla.gnome.org/show_bug.cgi?id=687967
Comment 2 Cosimo Cecchi 2012-11-09 15:39:47 UTC 
Review of attachment 228544 [details] [review]:

Looks good to me
Comment 3 Stef Walter 2012-11-09 16:29:21 UTC 
Attachment 228544 [details] pushed as c8de9ab - icon-theme: Add some preconditions for NULL arguments