After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687958 - power: "0 minutes remaining" when exactly 60 minutes are remaining
power: "0 minutes remaining" when exactly 60 minutes are remaining
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-09 04:00 UTC by Sebastian Keller
Modified: 2012-11-09 16:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
indicate 1 hour remaining correctly (1.02 KB, patch)
2012-11-09 04:13 UTC, Sebastian Keller 		committed Details | Review

Description Sebastian Keller 2012-11-09 04:00:32 UTC 
This problem is caused by http://git.gnome.org/browse/gnome-shell/tree/js/ui/status/power.js?id=f30dcad8a711069c58f35863ac5c0046ea48d7b6#n99
It should be >= 60 rather than > 60 because otherwise it goes into the else case with 60%60=0 minutes remaining.

I'm going to attach a patch to fix this.
Comment 1 Sebastian Keller 2012-11-09 04:13:45 UTC 
Created attachment 228523 [details] [review]
indicate 1 hour remaining correctly
Comment 2 Florian Müllner 2012-11-09 06:56:08 UTC 
Review of attachment 228523 [details] [review]:

Obviously correct - should go to gnome-3-6 as well.