GNOME Bugzilla – Bug 687932
Add schemas for notification filtering
Last modified: 2012-12-20 21:52:33 UTC
For the 3.8 feature, add schemas for notification settings, both a master schema and one for individual applications. These will be used by gnome-shell and gnome-control-center.
Created attachment 228498 [details] [review] Add schemas for notification filtering
Review of attachment 228498 [details] [review]: Looks good otherwise. ::: schemas/org.gnome.desktop.notifications.gschema.xml.in.in @@ +56,3 @@ + <_description> + Whether notification banners for this application are shown or not. Does not + affect summary mode. What's summary mode? Could you expand?
Can you update the patch, Giovanni?
Created attachment 230311 [details] [review] Add schemas for notification filtering For the 3.8 feature, add schemas for notification settings, both a master schema and one for individual applications. These will be used by gnome-shell and gnome-control-center. I could not find a better way to describe that.
Review of attachment 230311 [details] [review]: ::: schemas/org.gnome.desktop.notifications.gschema.xml.in.in @@ +43,3 @@ + </key> + + <key name="enable-sound" type="b"> enable-sound-alerts @@ +47,3 @@ + <_summary>Enable sound</_summary> + <_description> + Whether notifications should be accompained by alert sounds. "accompanied" and "sound alerts". @@ +80,3 @@ + <_summary>Be resident in the lock screen</_summary> + <_description> + Whether notifications from this application are shown as resident (fully and with details) when the screen is locked. I'll expand the definition of resident here.
Pushed a patch with slightly revised descriptions and key names. Please check that the descriptions are factually correct too.
There is one slight incorrectness. resident-in-lock-screen may be a bad name, but it refers to the fact that in the current implementation resident notifications are shown individually and fully (with details, action buttons and images), instead of being grouped by source, and resident-in-lock-screen forces notifications that are not normally resident to get that treatment. In the control center panel, it is bound to the "Show details in the lock screen" switch.
(In reply to comment #7) > There is one slight incorrectness. > resident-in-lock-screen may be a bad name, but it refers to the fact that in > the current implementation resident notifications are shown individually and > fully (with details, action buttons and images), instead of being grouped by > source, and resident-in-lock-screen forces notifications that are not normally > resident to get that treatment. > In the control center panel, it is bound to the "Show details in the lock > screen" switch. Does "Whether notifications from this application will be shown individually in full (with details, action buttons and images) in the lock screen." sound good?
(In reply to comment #8) > > Does "Whether notifications from this application will be shown individually in > full (with details, action buttons and images) in the lock screen." sound good? I guess that might work.
Done.