After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687910 - Move input source switcher setting to shortcuts typing section
Move input source switcher setting to shortcuts typing section
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
: 687731 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-08 11:15 UTC by Matthias Clasen
Modified: 2013-01-14 11:12 UTC
See Also:
GNOME target: 3.8
GNOME version: ---


Attachments
Add input0-source-switcher to the keyboard panel (11.38 KB, patch)
2013-01-14 00:54 UTC, Matthias Clasen
accepted-commit_now Details | Review

Description Matthias Clasen 2012-11-08 11:15:21 UTC
We only relegated it to the tweak tool in 3.6 because it came too late.
Lets move it in its proper place for 3.8.
Comment 1 Allan Day 2012-11-13 12:27:55 UTC
You should be able to configure "Switch to next source" and "Switch to previous source" to use two modifier keys directly from System Settings. I don't think this should require an extra section or entry in the keyboard shortcuts - you should be able to do it from the existing entries in the typing section.
Comment 2 Rui Matos 2012-11-13 13:09:03 UTC
(In reply to comment #1)
> You should be able to configure "Switch to next source" and "Switch to previous
> source" to use two modifier keys directly from System Settings. I don't think
> this should require an extra section or entry in the keyboard shortcuts - you
> should be able to do it from the existing entries in the typing section.

Seems hard to do on the same widget. How do you know that the user intends to use Ctrl+Alt for the shortcut and not Ctrl+Alt+Space for instance ?
Comment 3 Allan Day 2012-11-13 14:13:27 UTC
(In reply to comment #2)
> Seems hard to do on the same widget. How do you know that the user intends to
> use Ctrl+Alt for the shortcut and not Ctrl+Alt+Space for instance ?

As discussed on IRC, one way you could do this would be to update the shortcut after the keys have been released (if more than one modifier has been held down at once).
Comment 4 Bastien Nocera 2012-11-13 14:20:55 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Seems hard to do on the same widget. How do you know that the user intends to
> > use Ctrl+Alt for the shortcut and not Ctrl+Alt+Space for instance ?
> 
> As discussed on IRC, one way you could do this would be to update the shortcut
> after the keys have been released (if more than one modifier has been held down
> at once).

I'll give Allan the task of determining whether the Caps Lock or Num Lock keys are being used as part of the shortcut, or people are just typing numbers or using CAPS. :)

All that to say that you can't do that.

Rui, use a drop-down menu. I believe that the wacom panel (for which there is a test app) has that functionality in a patch somewhere. CC:'ing ofourdan
Comment 5 Matthias Clasen 2012-11-20 13:46:05 UTC
Rui: how about something like a combo box entry - predefined choices for modifier-only combinations, and the entry operates like regular accel cell renderer.
Comment 6 Rui Matos 2012-11-25 16:46:59 UTC
*** Bug 687731 has been marked as a duplicate of this bug. ***
Comment 7 Matthias Clasen 2013-01-14 00:54:20 UTC
Created attachment 233408 [details] [review]
Add input0-source-switcher to the keyboard panel
Comment 8 Rui Matos 2013-01-14 11:07:27 UTC
Review of attachment 233408 [details] [review]:

Looks as good as this thing is going to get I think. Just a minor comment below.

::: panels/keyboard/cc-keyboard-option.c
@@ +104,3 @@
 };
 
+GSettings *input_switcher_settings;

static missing here