After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687806 - mpegtsmux: Fix PTS being incorrectly created
mpegtsmux: Fix PTS being incorrectly created
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 1.0.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 688357 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-11-06 21:43 UTC by Kevin Thornberry
Modified: 2012-11-18 22:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix bad PTS creation in mpegtsmux (1.96 KB, patch)
2012-11-06 21:43 UTC, Kevin Thornberry 		committed Details | Review

Description Kevin Thornberry 2012-11-06 21:43:59 UTC 
Created attachment 228314 [details] [review]
Patch to fix bad PTS creation in mpegtsmux

This is possibly the same thing as https://bugzilla.gnome.org/show_bug.cgi?id=587881

Attached patch does two things:
- remove code that stops current PTS being earlier than previous one (why is this code here? PTSs can be out-of-order).
- fix PTS being given value of DTS

Thanks
Kev
Comment 1 Tim-Philipp Müller 2012-11-07 20:41:11 UTC 
Thanks for the patch! Pushed:

 commit c2d4c0da5e4c7121aff5bdb716e3d5ae0105686b
 Author: Kevin Thornberry <gimmeamilkbttf@gmail.com>
 Date:   Tue Nov 6 20:51:10 2012 +0000

    mpegtsmux: fix DTS value being used for PTS
    
    https://bugzilla.gnome.org/show_bug.cgi?id=687806
Comment 2 Jan Schmidt 2012-11-08 00:20:11 UTC 
The remnant of code checking for PTS going backwards comes from 0.10, where there was no DTS available, and mpegtsmux was using maximum-seen-PTS as a proxy for DTS in order to output monotonically increasing output timestamps
Comment 3 Tim-Philipp Müller 2012-11-18 22:15:56 UTC 
*** Bug 688357 has been marked as a duplicate of this bug. ***