After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687766 - quartz_application_* becomes gtkosx_application_* in Gtk_mac_integration >= 2.0.0
quartz_application_* becomes gtkosx_application_* in Gtk_mac_integration >= 2...
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other Mac OS
: High critical
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2012-11-06 14:59 UTC by Pierre Boutillier
Modified: 2013-04-07 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to make it compile on my computer (and attempt to correct configure.ac) (1.41 KB, patch)
2012-11-06 14:59 UTC, Pierre Boutillier 		none Details | Review

Description Pierre Boutillier 2012-11-06 14:59:42 UTC 
Created attachment 228257 [details] [review]
patch to make it compile on my computer (and attempt to correct configure.ac)

is it possible to update the gnome-2-30 branch (the one used by jhbuild under macOS) on that purpose ?

I've tried to make a patch ...
Comment 1 Philip Chimento 2013-01-14 12:31:27 UTC 
Ping?

Ditto on the gnome-3-6 branch.

In addition, the latest master also requires the following:

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 62d904d..0df0883 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -63,6 +63,7 @@ test_regex_SOURCES = test-regex.c
 test_regex_LDADD = 						\
 	$(top_builddir)/gtksourceview/libgtksourceview-private.la	\
 	$(DEP_LIBS)			\
+	$(GTK_MAC_LIBS)		\
 	$(TESTS_LIBS)
 
 UNIT_TEST_PROGS += test-completion-model
Comment 2 Philip Chimento 2013-04-01 18:46:49 UTC 
Ping?

May I commit this to gnome-2-30, gnome-3-6, and master? (After re-testing of course.) The build has been broken for a while on OS X.
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-04-01 19:01:13 UTC 
Looks good to me to push in 3-6 and master.
Comment 4 Philip Chimento 2013-04-02 11:25:00 UTC 
OK, will test and push as soon as possible. Can I also push to gnome-2-30?
Comment 5 Philip Chimento 2013-04-07 12:39:48 UTC 
Tested and pushed. I also figured it was OK to push to gnome-2-30 because the last activity there was my previous commit for fixing the build on OS X for gtk-mac-integration's previous API change ;-)

Thank you Pierre for the patch!