After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687637 - Port to python 3
Port to python 3
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks: python3
 
 
Reported: 2012-11-05 13:02 UTC by Stef Walter
Modified: 2016-04-07 08:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Port to python 3 (8.50 KB, patch)
2012-11-05 13:02 UTC, Stef Walter
none Details | Review
build: Port to Python 3 (5.38 KB, patch)
2016-04-06 08:42 UTC, Dmitry Shachnev
none Details | Review
libsecret: Get rid of PyGI warnings about unspecified versions (1.53 KB, patch)
2016-04-06 08:44 UTC, Dmitry Shachnev
none Details | Review

Description Stef Walter 2012-11-05 13:02:14 UTC
See https://live.gnome.org/GnomeGoals/Python3Porting
Comment 1 Stef Walter 2012-11-05 13:02:18 UTC
Created attachment 228106 [details] [review]
Port to python 3
Comment 2 Stef Walter 2012-11-05 13:08:54 UTC
Waiting for a fedora package of dbus-python before building.
Comment 3 Javier Jardón (IRC: jjardon) 2012-11-06 02:23:47 UTC
Hi Stef,

dbus-python is deprecated as well, the recommended way is to use GDBus via gobject-introspection, see https://bugs.freedesktop.org/show_bug.cgi?id=40661
Comment 4 Stef Walter 2012-11-06 05:27:45 UTC
Is there a non sucky method for implementing dbus services in python using GDBus? Like with annotations and stuff? Because plain ol' GDBus is really sucky in comparison.
Comment 5 Javier Jardón (IRC: jjardon) 2016-02-15 14:17:45 UTC
Part of this has been done in https://bugzilla.gnome.org/show_bug.cgi?id=761834
Comment 6 Dmitry Shachnev 2016-02-15 18:22:07 UTC
The remaining part is just replacing python with python3 in shebangs and command lines, right?

If there is something more complicated, please point me to it and I'll try to port it.
Comment 7 Dmitry Shachnev 2016-04-06 08:42:51 UTC
Created attachment 325463 [details] [review]
build: Port to Python 3

Attached the patch to port the remaining parts of buildsystem to Python 3.
Comment 8 Dmitry Shachnev 2016-04-06 08:44:15 UTC
Created attachment 325464 [details] [review]
libsecret: Get rid of PyGI warnings about unspecified versions

Not directly related to Python 3 port, but this removes these warnings from PyGI:

sys:1: PyGIWarning: MockService was imported without specifying a version first. Use gi.require_version('MockService', '0') before import to ensure that the right version gets loaded.
sys:1: PyGIWarning: Secret was imported without specifying a version first. Use gi.require_version('Secret', '1') before import to ensure that the right version gets loaded.
Comment 9 Stef Walter 2016-04-07 08:19:42 UTC
Attachment 325463 [details] pushed as d50dbae - build: Port to Python 3
Attachment 325464 [details] pushed as ae5761c - libsecret: Get rid of PyGI warnings about unspecified versions
Comment 10 Stef Walter 2016-04-07 08:20:03 UTC
Thanks. Checked and pushed to master.