After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687590 - "Ejecting drive '%s' failed:" What is %s exactly?
"Ejecting drive '%s' failed:" What is %s exactly?
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-04 20:44 UTC by Pavol Klačanský
Modified: 2017-08-03 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
drive-menu: Add a translator comment explaining a variable (869 bytes, patch)
2017-08-02 15:12 UTC, Piotr Drąg
committed Details | Review

Description Pavol Klačanský 2012-11-04 20:44:48 UTC
#: ../extensions/drive-menu/extension.js:72
#, c-format
msgid "Ejecting drive '%s' failed:"

Hi what is %s? is it only CDROM or also USB key?
Comment 1 Hashem Nasarat 2013-01-27 21:59:48 UTC
The %s is a string with the name of a GMount, which I assume can be mounted filesystem:
http://developer.gnome.org/gio/unstable/GMount.html#GMount.description

Also, this isn't a bug, please ask on IRC or the mailing list next time.
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-01-27 22:03:27 UTC
No, this is the appropriate place to ask for such bugs. We need to add a translator comment.
Comment 3 André Klapper 2013-01-27 22:20:15 UTC
(In reply to comment #1)
> this isn't a bug, please ask on IRC or the mailing list next time.

Expecting dozens of translators to ask on IRC individually and expecting developers to answer the same question again and again (instead of documenting meanings of strings properly) IS a valid bug. ;)
See https://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments for how to fix this.
Comment 4 Piotr Drąg 2017-08-02 15:12:45 UTC
Created attachment 356788 [details] [review]
drive-menu: Add a translator comment explaining a variable
Comment 5 Florian Müllner 2017-08-03 09:51:47 UTC
Review of attachment 356788 [details] [review]:

OK
Comment 6 Piotr Drąg 2017-08-03 12:07:07 UTC
Comment on attachment 356788 [details] [review]
drive-menu: Add a translator comment explaining a variable

Thank you!

https://git.gnome.org/browse/gnome-shell-extensions/commit/?id=71ba8b04d79545777ddc00ed574f775a0a61a265