Bug 687409 – 0.4.4 Fails to run

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 687409 - 0.4.4 Fails to run


Summary:	0.4.4 Fails to run


Status:	RESOLVED FIXED

Product:	caribou
Classification:	Applications
Component:	default
Version:	0.4.x
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	caribou-maint
QA Contact:	caribou-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-11-02 06:05 UTC by Balló György
Modified:	2012-12-20 02:23 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Fix border-image slice values in antler's gtk CSS (905 bytes, patch) 2012-11-02 06:30 UTC, Daiki Ueno	committed	Details \| Review

Description Balló György 2012-11-02 06:05:59 UTC

When I try to launch caribou, I get the following error:

  "Error starting Caribou
   Process /usr/lib/caribou/antler-keyboard exited with status 1"


When I try to run /usr/lib/caribou/antler-keyboard, I get the following trackback:

Traceback (most recent call last):

+ Trace 231123

File "<string>", line 3 in <module>
File "/usr/lib/python2.7/site-packages/caribou/antler/main.py", line 10 in __init__
```
self.window = AntlerWindowEntry(AntlerKeyboardView)
```
File "/usr/lib/python2.7/site-packages/caribou/antler/window.py", line 411 in __init__
```
AntlerWindow.__init__(self, keyboard_view_factory, placement)
```
File "/usr/lib/python2.7/site-packages/caribou/antler/window.py", line 223 in __init__
```
self.keyboard_view = keyboard_view_factory (settings.keyboard_type.value)
```
File "/usr/lib/python2.7/site-packages/caribou/antler/keyboard_view.py", line 260 in __init__
```
[GLib.get_user_data_dir()] + list(GLib.get_system_data_dirs()))
```
File "/usr/lib/python2.7/site-packages/caribou/antler/keyboard_view.py", line 323 in _load_style
```
provider.load_from_path(fn)
```
File "/usr/lib/python2.7/site-packages/gi/types.py", line 47 in function
```
return info.invoke(*args, **kwargs)
```

gi._glib.GError: style.css:15:46`px' is not a valid unit.



Reverting this commit solves the problem:

  http://git.gnome.org/browse/caribou/commit/data/antler/style.css?id=44cb54c723349097b9703ec439e4596b6c49d693


I'm using Arch Linux with the latest stable packages:

- glib2 2.34.1
- gtk3 3.6.1
- gobject-introspection 1.34.1.1
- pygobject 3.4.1.1
- caribou 0.4.4

Comment 1 Daiki Ueno 2012-11-02 06:30:38 UTC

Created attachment 227871 [details] [review]
Fix border-image slice values in antler's gtk CSS

According to CSS spec, border-image slice values are not denoted
with length units.
--
Thanks, I was also experiencing the same issue and commented the corresponding line in my local tree.

According to http://www.w3.org/TR/css3-background/#border-image-slice

"<number> Numbers represent pixels in the image (if the image is a raster image) or vector coordinates (if the image is a vector image)."

Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-11-02 11:49:49 UTC

Review of attachment 227871 [details] [review]:

Looks good to me

Comment 3 Daiki Ueno 2012-11-02 12:15:42 UTC

Comment on attachment 227871 [details] [review]
Fix border-image slice values in antler's gtk CSS

Thanks for the review.

Attachment 227871 [details] pushed as a8fb1d8 - Fix border-image slice values in antler's gtk CSS

Comment 4 Daiki Ueno 2012-12-20 02:23:21 UTC

Fixed in 0.4.4.2 and 0.4.5.