GNOME Bugzilla – Bug 687202
If trashing fails, the ".trashinfo" file is not removed
Last modified: 2013-10-31 04:41:47 UTC
Steps with Thunar: 1) Create a directory that will not have permissions to be deleted: mkdir -m 500 directory-test 2) Open Thunar, right-click on "directory-test" and choose to delete it. An error will occur because of insufficient permissions. Actual result: an empty information file "/home/user/.local/share/Trash/info/directory-test.trashinfo" remains. Expected result: the information file should be deleted. More information: previously reported for Thunar: https://bugzilla.xfce.org/show_bug.cgi?id=8614 but closed with he following message: > GIO issue, because thunar is not aware of the info file, > it only calls g_file_trash and displays the error on failure. > > Report upstream.
This problem is actually in glib/gio since this happens when trashing a local directory/file.
Created attachment 258606 [details] [review] gio: Clean up trashinfo file if trashing fails
Review of attachment 258606 [details] [review]: Looks like we're still leaving around the info/ and files/ directories, but eh, whatever. Looks good!
Pushed to master a e2fcb77. (In reply to comment #3) > Review of attachment 258606 [details] [review]: > > Looks like we're still leaving around the info/ and files/ directories, but eh, > whatever. Looks good! I don't really think that's a problem since they're part of the trash format and there are likely to be other files in the trash anyway.