After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687089 - g_dbus_connection_export_menu_model(): fix a crash
g_dbus_connection_export_menu_model(): fix a crash
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gapplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-10-29 08:16 UTC by Allison Karlitskaya (desrt)
Modified: 2012-10-29 15:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
g_dbus_connection_export_menu_model(): fix a crash (1.93 KB, patch)
2012-10-29 08:16 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-10-29 08:16:57 UTC 
A few people have been noticing this...
Comment 1 Allison Karlitskaya (desrt) 2012-10-29 08:16:58 UTC 
Created attachment 227506 [details] [review]
g_dbus_connection_export_menu_model(): fix a crash

Add some extra protection when 'preparing' a group that doesn't yet
contain any menus.  This can happen if you subscribe to a group that
doesn't yet exist.

It was possible to crash any application using
g_dbus_connection_export_menu_model() by requesting a non-existent
subscription group over the bus.

In practice this only happened in races -- where the proxy sees a group
that exists and queries it, but by the time it does, it's already gone.
Comment 2 Matthias Clasen 2012-10-29 11:52:03 UTC 
Review of attachment 227506 [details] [review]:

Makes sense
Comment 3 Allison Karlitskaya (desrt) 2012-10-29 15:19:08 UTC 
Attachment 227506 [details] pushed as f20ae7f - g_dbus_connection_export_menu_model(): fix a crash