After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687066 - gtk 3.6.1 fails to build for win32
gtk 3.6.1 fails to build for win32
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.6.x
Other Windows
: Normal major
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
: 684600 688775 695368 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-28 21:41 UTC by Hib Eris
Modified: 2013-03-08 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0001-Fix-compiling-for-win32.patch (1.96 KB, patch)
2012-10-28 21:41 UTC, Hib Eris
accepted-commit_now Details | Review

Description Hib Eris 2012-10-28 21:41:52 UTC
Created attachment 227484 [details] [review]
0001-Fix-compiling-for-win32.patch

Compiling gtk-launch.c for win32 fails because it includes gdesktopappinfo.h, which is only available for unix.

Patch attached.
Comment 1 Matthias Clasen 2012-10-29 01:22:04 UTC
Review of attachment 227484 [details] [review]:

Looks good to me
Comment 2 Hib Eris 2012-10-29 08:41:14 UTC
I have pushed the patch to master. Should I also push it to gtk-3-6 ?
Comment 3 André Klapper 2012-11-22 15:45:34 UTC
*** Bug 684600 has been marked as a duplicate of this bug. ***
Comment 4 André Klapper 2012-11-22 15:45:40 UTC
*** Bug 688775 has been marked as a duplicate of this bug. ***
Comment 5 Matthias Clasen 2013-01-21 03:21:45 UTC
cherry-picked to 3.6
Comment 6 Hib Eris 2013-03-08 09:32:54 UTC
*** Bug 695368 has been marked as a duplicate of this bug. ***