GNOME Bugzilla – Bug 687015
Option to close scores/finished window without forcing a new game.
Last modified: 2013-11-19 17:00:52 UTC
When you've completed a game, the scores window pops up in front of your game (if you're in the top ten) or if you aren't another window pops up to say that you finished but didn't score in the top ten. You have the following options to continue: 1) Press New Game to go to the game-size selector. 2) Press Quit to quit the program entirely. 3) Close the pop-up window with the X in the corner (or similar mechanism depending on your window manager and theme) or pressing escape. This results in the same behaviour as #1 above. It would make more sense to allow you to just close the pop-up window so you can still observe your completed game. This could be achieved by: 1) Adding a third button ("Close"). and/or 2) Changing the action linked to closing the pop-up window.
All the Vala games with scores behave this way. A close button probably makes sense for many of them (including Mines), but not all (e.g. Mahjongg, where you have nothing left on the board).
Created attachment 259345 [details] [review] Allow nice closing of scores window This patch implements both points.
Review of attachment 259345 [details] [review]: I think we should just replace the Quit button for Mines. Having three buttons doesn't look very good - it forces the dialog to be unnecessarily wide.
Created attachment 259565 [details] [review] (Version 2) Allow nice closing of scores window I think you are right,
Comment on attachment 259565 [details] [review] (Version 2) Allow nice closing of scores window Again leaving open for a few days as a reminder for me to check other games.
Done for Klotski as well. Mario, do you want this change for Quadrapassel? I think that's the only other game where this might make sense.
You are right, this seems quite applicable to quadrapassel and I'd be happy to have that change in master. Thank you :)
Done, thanks everyone.