After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686903 - No tooltip in the toolbar
No tooltip in the toolbar
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Main Toolbar
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-26 00:16 UTC by Stefan Knorr
Modified: 2012-12-13 11:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add tooltips for search, grid and list button (1.85 KB, patch)
2012-12-12 18:16 UTC, Michael Wood
rejected Details | Review

Description Stefan Knorr 2012-10-26 00:16:04 UTC
Nautilus 3.6.0 – 3.7.1 does not have tooltips for its toolbar. I.e., there should be popups for "Back (Alt-Left)," "Forward (Alt-Right)," "Search (Ctrl-F)," "List View," "Icon View," "View," and "Tools (F10)."
Comment 1 Cosimo Cecchi 2012-10-26 20:46:01 UTC
Thanks, I pushed a fix for this now.
We already have translatable strings for all the buttons, except for the two menus; I split the fix into two commits so that the one adding tooltips for non-menu buttons can also backported to gnome-3-6 without breaking string freeze.
Comment 2 Michael Wood 2012-12-12 18:16:44 UTC
Created attachment 231402 [details] [review]
Add tooltips for search, grid and list button

Search, Grid and list were still missing tooltips. I think back and forward still need them but couldn't find the right wording for Forward to a previously visited folder vs also Backward to previously visited.
Comment 3 Cosimo Cecchi 2012-12-12 18:25:17 UTC
Review of attachment 231402 [details] [review]:

Those specific tooltips seem to work fine already in git master and 3.6.3 for me.
See [1] and [2]. The second commit is not in 3.6 since it added new strings too late.

[1] http://git.gnome.org/browse/nautilus/commit/?id=1af5f7c3b90539506d56295dfa09f98021bb60b0
[2] http://git.gnome.org/browse/nautilus/commit/?id=f017a93b9ba3a465059ebca8eeb79138c983bd96
Comment 4 Michael Wood 2012-12-13 11:56:04 UTC
Hmm, I'm using Nautilus master and don't see the tooltips for search,grid and list. 

The diff you linked shows 

+ tool_button = toolbar_create_toolbutton (self, FALSE, TRUE, NAUTILUS_ACTION_SEARCH, NULL);

+ tool_button = toolbar_create_toolbutton (self, FALSE, TRUE, NAUTILUS_ACTION_VIEW_LIST, NULL);

+ tool_button = toolbar_create_toolbutton (self, FALSE, TRUE, NAUTILUS_ACTION_VIEW_GRID, NULL);

All NULL for tooltips. My patch adds values for these, unless I'm missing something.