After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686820 - GMenu initially checks wrong radio menu item
GMenu initially checks wrong radio menu item
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
unspecified
Other Linux
: Normal major
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-24 19:06 UTC by Christian Persch
Modified: 2013-09-19 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix "group-by" settings logic (2.42 KB, patch)
2013-09-01 10:25 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Christian Persch 2012-10-24 19:06:08 UTC
Steps to repro:
0) set gtk-shell-shows-app-menu = false
1) set /org/gnome/charmap/group-by to 'block'
2) start gucharmap
3) click on the 'view' menu in the menubar

Observe: the charmap shows in 'block' mode, but the 'By Script' menu item is checked instead of the "By Unicode Block" menu item.
Comment 1 Christian Persch 2012-10-24 19:06:31 UTC
(This is with gucharmap git master, using gtk+ git master.)
Comment 2 Matthias Clasen 2013-08-31 20:51:28 UTC
I don't see any attempt to match the initial state of the action to the setting.
This should probably be redone with GSettingsAction.
Comment 3 Allison Karlitskaya (desrt) 2013-09-01 10:25:46 UTC
Created attachment 253741 [details] [review]
Fix "group-by" settings logic

Use a GSettingsAction to ensure that the radio menu items are properly
synced to the value from GSettings and simplify the logic for dealing
with changes.
Comment 4 Allison Karlitskaya (desrt) 2013-09-09 21:29:00 UTC
Someone should probably review and/or push this before the release.... It's pretty broken in its current state.