Bug 686815 – main: Stop passing a file global variable around as a parameter

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 686815 - main: Stop passing a file global variable around as a parameter


Summary:	main: Stop passing a file global variable around as a parameter

Attachments
main: Stop passing a file global variable around as a parameter (3.28 KB, patch) 2012-10-24 17:21 UTC, Rui Matos	rejected	Details \| Review

Description Rui Matos 2012-10-24 17:21:35 UTC

A small cleanup.

Comment 1 Rui Matos 2012-10-24 17:21:51 UTC

Created attachment 227177 [details] [review]
main: Stop passing a file global variable around as a parameter

Comment 2 Bastien Nocera 2012-10-26 08:03:46 UTC

Review of attachment 227177 [details] [review]:

I'd rather make it not be a global variable.

Comment 3 Benjamin Berg 2019-02-01 13:30:58 UTC

I think I agree with Bastien here. We probably want to avoid global variables in general.