After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686696 - jhbuild --check fails because tests failed to build
jhbuild --check fails because tests failed to build
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-23 10:39 UTC by JB Lallement
Modified: 2012-11-29 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch to add explicit link to required objects (788 bytes, patch)
2012-10-23 10:40 UTC, JB Lallement
committed Details | Review

Description JB Lallement 2012-10-23 10:39:26 UTC
Running "jhbuild build --check librsvg" on Ubuntu 12.10 failed because tests failed to build with the following error:
"""
make  check-TESTS
make[4]: Entering directory `/home/j-lallement/checkout/gnome/librsvg/tests'
  CC     rsvg-test.o
In file included from rsvg-test.c:43:0:
../rsvg-cairo.h:27:2: warning: #warning "Including <librsvg/rsvg-cairo.h> directly is deprecated." [-Wcpp]
rsvg-test.c: In function ‘rsvg_test_log’:
rsvg-test.c:66:5: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wmissing-format-attribute]
rsvg-test.c: In function ‘rsvg_test_html’:
rsvg-test.c:77:5: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wmissing-format-attribute]
rsvg-test.c: In function ‘rsvg_cairo_check’:
rsvg-test.c:258:5: warning: ‘rsvg_handle_set_size_callback’ is deprecated (declared at ../rsvg.h:201) [-Wdeprecated-declarations]
  CCLD   rsvg-test
/usr/bin/ld: rsvg-test.o: undefined reference to symbol 'g_object_unref'
/usr/bin/ld: note: 'g_object_unref' is defined in DSO /opt/gnome/lib64/libgobject-2.0.so.0 so try adding it to the linker command line
/opt/gnome/lib64/libgobject-2.0.so.0: could not read symbols: Invalid operation
collect2: error: ld returned 1 exit status
"""

The proposed patch attached addresses this issue
Comment 1 JB Lallement 2012-10-23 10:40:54 UTC
Created attachment 227047 [details] [review]
proposed patch to add explicit link to required objects
Comment 2 Christian Persch 2012-11-29 13:27:38 UTC
Ping? can you commit?
Comment 3 Martin Pitt 2012-11-29 14:10:42 UTC
I'm happy to commit for JB, but usually this requires an ack from a project maintainer first.
Comment 4 Christian Persch 2012-11-29 14:16:37 UTC
The patch is marked a-c-n (by me, and I'm an rsvg maintainer), so should be ok :-)
Comment 5 Martin Pitt 2012-11-29 14:25:17 UTC
Sorry, I missed that! Committed with a reference to the bug.

Thanks Jean-Baptiste!