After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686579 - ensure session registration happens before other idles
ensure session registration happens before other idles
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-21 15:25 UTC by Matthias Clasen
Modified: 2012-10-22 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.40 KB, patch)
2012-10-21 15:25 UTC, Matthias Clasen 		accepted-commit_now Details | Review
main: Ensure session registration happens before other idles (2.60 KB, patch)
2012-10-22 08:19 UTC, Bastien Nocera 		committed Details | Review

Description Matthias Clasen 2012-10-21 15:25:19 UTC 
Created attachment 226929 [details] [review]
patch

We're deferring a bunch of slow stuff to idles, to have it happen after session registration and not slow down login - but I've observed that the ordering is unreliable - sometimes we end up doing the RegisterClient call after the initial set of idles. 

It turns out the Ubuntu ships a patch to address this - they must not have gotten around to sending it upstream...
Comment 1 Bastien Nocera 2012-10-21 20:09:41 UTC 
Review of attachment 226929 [details] [review]:

++
Comment 2 Bastien Nocera 2012-10-22 08:19:01 UTC 
Created attachment 226968 [details] [review]
main: Ensure session registration happens before other idles

We're deferring some slower operations to idles, in plugins,
to have it happen after session registration and not slow down
login - but I've observed that the ordering is unreliable.

Sometimes we end up doing the RegisterClient call after the
initial set of idles.

Ensure that the session registration happens before other idles by
making the idle higher priority than the plugins.
Comment 3 Bastien Nocera 2012-10-22 08:22:59 UTC 
Attachment 226968 [details] pushed as dcb54d8 - main: Ensure session registration happens before other idles