Created attachment 226849 [details] [review]
Use libgnome-volume-control from a submodule

To be shared with gnome-settings-daemon and gnome-shell

Review of attachment 226849 [details] [review]:

gvc-mixer-dialog.h is still in the submodule.
the gitmodules file needs to state a revision.

I fixed gvc-mixer-dialog and gvc-channel-bar in current master, and will post an updated patch.

.gitmodules does not include a revision, as that is tracked by git automatically in the superproject. If you fetch a submodule explicitly, git status will report it as dirty, and you'll need to commit it.

Created attachment 227019 [details] [review]
Use libgnome-volume-control from a submodule

To be shared with gnome-settings-daemon and gnome-shell

The whole point of using a submodule is so that we can set a particular revision of the module to check out and avoid breaking everything when we make changes for one of the modules.

And that's what I said.
Again, a git submodule is always locked to the specific commit, whose hash is stored in the blob file for the submodule directory.
If you want to change that hash, you need to cd inside the submodule, checkout a new revision, go back to the superproject and make a commit. There is no way to "update" the submodule from the superproject (git fetch is recursive, but that's irrelevant), and if you don't commit the revision change, git submodule update will revert the submodule to the latest stored hash.

Attachment 227019 [details] pushed as f1812b2 - Use libgnome-volume-control from a submodule