GNOME Bugzilla – Bug 686474
The active area of tray items should extend to the edge of the screen.
Last modified: 2012-10-26 14:33:08 UTC
If I try to click on a tray item and have the mouse pointer against the bottom of the screen, nothing happens - there is a gap between the tray item and the bottom of the screen. Visually, this gap is fine, but it should respond to clicks.
Created attachment 227321 [details] [review] message-tray: Restore Fittsability of summary items The reactive area of tray items should extend to the screen edge. This regressed when implementing the new tray design, make it work again.
Review of attachment 227321 [details] [review]: Looks fine but I would squash the following on this patch so that there's no "dead" gap between the buttons: diff --git a/data/theme/gnome-shell.css b/data/theme/gnome-shell.css index 2aec8bb..2e4b82d 100644 --- a/data/theme/gnome-shell.css +++ b/data/theme/gnome-shell.css @@ -1432,11 +1432,10 @@ StScrollBar StButton#vhandle:active { #summary-mode { height: 72px; - spacing: 10px; } .summary-source-button { - padding: 6px 0 6px 0; + padding: 6px 3px 6px 3px; } .summary-source-button:last-child:ltr {
Created attachment 227359 [details] [review] message-tray: Restore Fittsability of summary items (In reply to comment #2) > Looks fine but I would squash the following on this patch so that there's no > "dead" gap between the buttons: > > [...] > > .summary-source-button { > - padding: 6px 0 6px 0; > + padding: 6px 3px 6px 3px; > } I'm assuming s/3/5/ to keep the existing spacing.
Review of attachment 227359 [details] [review]: (In reply to comment #3) > I'm assuming s/3/5/ to keep the existing spacing. I think it looks better if the inter button gap is the same size as the gap to the top and bottom. Ask a designer and push. Should go to the 3.6 branch too IMO.
Agreed on the horizontal spacing.
Attachment 227359 [details] pushed as 9396849 - message-tray: Restore Fittsability of summary items