GNOME Bugzilla – Bug 686136
Better warning and error messages.
Last modified: 2017-11-19 15:37:38 UTC
At the moment when analysing / the wording of the warning presented in the infobar is vauge and not very usefull to the user. It says: 'Could not scan folder "/" or some of the folders containing it. Permission denied'. It doesn't tell the user the what happens when that warning is present and it would be better to have an error if you can't scan the whole root folder (thinking about remote folders or volumes) and a warning if you can't scan some subfolder also.
Created attachment 226443 [details] [review] window: Be more specific when reporting scanning errors Use a warning message for subfolder error, an error message for top folder error.
It seems to me that we should also move away from using GErrors to control execution flow, since they are not meant to report recoverable errors. I'm talking about the block try { scanner.finish () } catch () { ... }
(In reply to comment #2) > It seems to me that we should also move away from using GErrors to control > execution flow, since they are not meant to report recoverable errors. Why? Sure they are meant for recoverable errors, just thing of g_file_create and handling G_IO_ERROR_EXISTS
Review of attachment 226443 [details] [review]: Patch looks ok as a first step once we branch. Though we probably need even better messages. Also we should make the location in the list insensitive and maybe display an hint if we detect the location root is not accessible
Created attachment 226444 [details] [review] Improve scanner error handling. Use a warning message for subfolder error, an error message for top folder error. --- Another version, based on a new error domain 'ScannerError'
Currently, in the treeview, the inaccessible location is shown in red and the parent folder in orange, but if it is nested in other folders is hard to find. It would be better if all parent directories were orange.
Created attachment 248543 [details] The situation at this time
Created attachment 248544 [details] A better solution with all the parent folders in orange This is related to the proposal at comment 6 (https://bugzilla.gnome.org/show_bug.cgi?id=686136#c6)
Pushed a fix implementing the behavior in comment 6 (which was the original intended behavior anyway...)
(In reply to comment #9) > Pushed a fix implementing the behavior in comment 6 (which was the > original intended behavior anyway...) commit 99de9a331f7371e0db90d5a8e4298facdb198531
Patch has "accepted-commit_after_freeze" status for 18 months now - please commit?
Comment on attachment 226443 [details] [review] window: Be more specific when reporting scanning errors Attachment 226443 [details] pushed as bc3deb0 - window: Be more specific when reporting scanning errors
Patches have been pushed, marking as fixed. Feel free to reopen if anything is missing.