After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686078 - gnome-sudoku crashes when trying to clear notes (solution provided)
gnome-sudoku crashes when trying to clear notes (solution provided)
Status: RESOLVED DUPLICATE of bug 707362
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal critical
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-13 09:22 UTC by 张海
Modified: 2013-09-05 22:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Removed two instances of always_show_hints (1.49 KB, patch)
2013-02-15 01:56 UTC, gapalp 		reviewed Details | Review

Description 张海 2012-10-13 09:22:37 UTC 
Hi, I'm a newcomer here and I noticed a bug in gnome-sudoku that the app crashes when notes are cleared (Ctrl+J), with the following info in terminal: 

GLib-GIO-ERROR **: Settings schema 'org.gnome.gnome-sudoku' does not contain a key named 'always_show_hints'

I downloaded the source and find the problem located at
http://git.gnome.org/browse/gnome-games/tree/gnome-sudoku/src/lib/main.py#n525

525 def do_clear_notes(self, side):
......
534        if side == 'Bottom' and self.settings.get_boolean('always_show_hints'):
......
538        if self.settings.get_boolean ('always_show_hints'):
......

the two string 'always_show_hints' should be 'always-show-hints' here and after I corrected the bug and recompiled the app it responded to Ctrl+J correctly. 

Would you please correct this bug? Because I'm new to the linux world, I just don't know how to do this.
Comment 1 gapalp 2013-02-15 01:56:10 UTC 
Created attachment 236205 [details] [review]
Removed two instances of always_show_hints
Comment 2 Michael Catanzaro 2013-08-15 23:28:04 UTC 
(In reply to comment #0) 
> Would you please correct this bug? Because I'm new to the linux world, I just
> don't know how to do this.

Thanks both of you for fixing this problem!
Comment 3 Michael Catanzaro 2013-08-15 23:32:15 UTC 
Review of attachment 236205 [details] [review]:

Thank you for your patch!  Could you please remove the comments you added in this patch; we don't generally add comments with bugfixes unless it's something that would be helpful to future programmers.  Once that's done, this is good to commit.
Comment 4 Michael Catanzaro 2013-08-15 23:32:15 UTC 
Review of attachment 236205 [details] [review]:

Thank you for your patch!  Could you please remove the comments you added in this patch; we don't generally add comments with bugfixes unless it's something that would be helpful to future programmers.  Once that's done, this is good to commit.
Comment 5 Michael Catanzaro 2013-09-05 22:10:03 UTC 
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.

*** This bug has been marked as a duplicate of bug 707362 ***