After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686023 - Ctrl+Z undoes rename even if editing another file's name
Ctrl+Z undoes rename even if editing another file's name
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.24.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 682661 719630 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-12 12:30 UTC by Bastien Nocera
Modified: 2017-08-08 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rename-file-popover-controller: consume ^Z (4.03 KB, patch)
2017-08-08 10:38 UTC, Ernestas Kulik 		committed Details | Review

Description Bastien Nocera 2012-10-12 12:30:00 UTC 
nautilus-3.6.0-1.fc18.x86_64

Instead, it should undo whatever editing I've done in the text field/filename edit box.

1. Rename file1 to blah1
2. Edit file2's name to arfarf2
3. Whilst still editing, press Ctrl+Z

What happens:
blah1 is renamed to file1, the 2nd file's name stays arfarf2

What is should do:
Keep me in the edit box, have arfarf2 renamed to file2
Comment 1 Cosimo Cecchi 2012-10-18 15:14:07 UTC 
*** Bug 682661 has been marked as a duplicate of this bug. ***
Comment 2 ar 2016-02-03 19:57:27 UTC 
Still present in 2016.
Comment 3 Ernestas Kulik 2017-04-07 14:26:22 UTC 
*** Bug 719630 has been marked as a duplicate of this bug. ***
Comment 4 Ernestas Kulik 2017-08-08 10:38:24 UTC 
Created attachment 357180 [details] [review]
rename-file-popover-controller: consume ^Z

Pressing ^Z while renaming a file results in undoing the last completed
operation, which breaks expectations. This commit makes ^Z revert the
text in the name entry to the display name of the target file.
Comment 5 Carlos Soriano 2017-08-08 14:14:06 UTC 
Review of attachment 357180 [details] [review]:

Nice, thanks Ernestas!

Just a nitpick, is usually better to use more user friendly communication for commit messages, in this case, <ctrl>+z rather than ^Z. But it's fine this time.
Comment 6 Ernestas Kulik 2017-08-08 17:06:21 UTC 
Attachment 357180 [details] pushed as bf6b1e2 - rename-file-popover-controller: consume ctrl-z