After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686002 - Clean up workspacesView a bit
Clean up workspacesView a bit
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-11 22:27 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-10-21 22:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspacesView: Remove some dead code (765 bytes, patch)
2012-10-11 22:27 UTC, Jasper St. Pierre (not reading bugmail) 		rejected Details | Review
workspacesView: Don't zoom out thumbnails on XDnD handling (1.83 KB, patch)
2012-10-11 22:27 UTC, Jasper St. Pierre (not reading bugmail) 		rejected Details | Review
workspacesView: Simplify extraWorkspaces handling (3.73 KB, patch)
2012-10-11 22:27 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-10-11 22:27:36 UTC 
Some old fixes. Nothing major, just thought I'd file them.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-11 22:27:39 UTC 
Created attachment 226297 [details] [review]
workspacesView: Remove some dead code
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-11 22:27:42 UTC 
Created attachment 226298 [details] [review]
workspacesView: Don't zoom out thumbnails on XDnD handling

We stopped zooming out thumbnails on regular DnD a while ago, so why
make an exception for XDnD?
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-11 22:27:45 UTC 
Created attachment 226299 [details] [review]
workspacesView: Simplify extraWorkspaces handling
Comment 4 Florian Müllner 2012-10-19 21:33:32 UTC 
Review of attachment 226297 [details] [review]:

Nope, that's not dead code.
Comment 5 Florian Müllner 2012-10-19 21:37:39 UTC 
Review of attachment 226298 [details] [review]:

The zooming out is reconsidered in bug 685312, so we probably don't want this.
Comment 6 Florian Müllner 2012-10-19 21:42:10 UTC 
Review of attachment 226299 [details] [review]:

The change looks good, though I haven't actually tested this.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-10-19 21:46:32 UTC 
Review of attachment 226297 [details] [review]:

It is. The _updateZoom call below will set it properly.
Comment 8 Florian Müllner 2012-10-19 21:54:35 UTC 
(In reply to comment #7)
> Review of attachment 226297 [details] [review]:
> 
> It is. The _updateZoom call below will set it properly.

Not when Main.overview.animationInProgress is true. The result of your patch is that the workspace area overlaps the switcher until something else calls _updateZoom() again (hovering the switcher for instance).
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-10-21 22:54:04 UTC 
Attachment 226299 [details] pushed as a0e0cc1 - workspacesView: Simplify extraWorkspaces handling