GNOME Bugzilla – Bug 685992
empathy strips the "+" (plus) from the numbers from the gnome-contacts
Last modified: 2013-01-22 16:58:10 UTC
1. open gnome-contacts and pick a contact which is in your emphathy roster 2. add a phone number for that contact (f.i. +49176.....) 3. create a sip-account and make it default for calling to "regular" phones 4. In the context menu of the contact you added the number for, you see "Call 49176..." - without plus 5. If you try and call on this number - it doesn't work.
This is because Empathy uses the output of folks’ PhoneFieldDetails.get_normalised() method to give the phone number to call. That method strips off leading ‘+’ symbols. Guillaume/Marco, should folks be doing this? Marco originally wrote the code, and I have no idea about SIP.
I don't think we should remove the leading '+'. Marco: what was the rational for removing this?
Created attachment 232330 [details] [review] phone-details: get_normalised: keep the leading '+' It's needed to be able to call phone numbers containing an international prefix.
Review of attachment 232330 [details] [review]: Committed to master (with a change to NEWS). Thanks. commit bf25b9b6031d65569eb87836325793637b1ddec1 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Fri Dec 28 15:11:25 2012 +0100 phone-details: get_normalised: keep the leading '+' It's needed to be able to call phone numbers containing an international prefix. https://bugzilla.gnome.org/show_bug.cgi?id=685992 NEWS | 2 ++ folks/phone-details.vala | 11 +++-------- 2 files changed, 5 insertions(+), 8 deletions(-)
Ok, I applied this patch to my local version of libfolks-0.8.0, but telephone numbers in my roster remained the same. How can I make empathy to reload the information from gnome-contacts?
(In reply to comment #5) > Ok, I applied this patch to my local version of libfolks-0.8.0, but telephone > numbers in my roster remained the same. How can I make empathy to reload the > information from gnome-contacts? It should be updated the next time you launch Empathy and it links against your patched version of the library. Both Empathy and Gnome Contacts use Folks so they get the same data sources. In most cases, any changes in the data sources are reflected immediately. But since you changed something that required the library to be reloaded, the application has to be restarted.