After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685982 - ClutterActor::transitions-completed isn't called for implicit transitions
ClutterActor::transitions-completed isn't called for implicit transitions
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-11 15:27 UTC by Tomeu Vizoso
Modified: 2012-12-18 02:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
actor: Remove transition when stopping it (1.39 KB, patch)
2012-10-11 15:27 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2012-10-11 15:27:30 UTC 
This happens with implicit transitions created by actor setters, even with
remove-on-complete set to TRUE.
Comment 1 Tomeu Vizoso 2012-10-11 15:27:33 UTC 
Created attachment 226270 [details] [review]
actor: Remove transition when stopping it

This covers more cases when the transition completes but was still
being tracked by its actor.
Comment 2 Tomeu Vizoso 2012-12-17 10:49:43 UTC 
Can this get a review, please?
Comment 3 Emmanuele Bassi (:ebassi) 2012-12-17 12:27:04 UTC 
Review of attachment 226270 [details] [review]:

looks okay; you can push it to master after changing the comment below, without re-attaching the patch.

::: clutter/clutter-actor.c
@@ +3940,3 @@
       TransitionClosure *closure = value;
 
       /* if the transition is implicit we just remove it now */

the comment should be updated as well, to something like:

  implicit transitions, and automatically managed explicit ones, should be removed at this point
Comment 4 Emmanuele Bassi (:ebassi) 2012-12-18 02:08:54 UTC 
pushed to master with the comment updated.