After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685897 - [PATCH] fsusage: Fix fetching rootfs stats on Fedora 17
[PATCH] fsusage: Fix fetching rootfs stats on Fedora 17
Status: RESOLVED FIXED
Product: libgtop
Classification: Core
Component: linux
2.28.x
Other Linux
: Normal normal
: ---
Assigned To: libgtop maintainers
libgtop maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-10 15:55 UTC by Cole Robinson
Modified: 2013-01-28 22:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fsusage: Fix fetching rootfs stats on Fedora 17 (1.28 KB, patch)
2012-10-10 15:55 UTC, Cole Robinson 		accepted-commit_now Details | Review

Description Cole Robinson 2012-10-10 15:55:15 UTC 
Created attachment 226183 [details] [review]
fsusage: Fix fetching rootfs stats on Fedora 17

On Fedora 17, my /etc/mtab has this:

$ grep " / " /etc/mtab
rootfs / rootfs rw 0 0
/dev/sda2 / ext4 rw,seclabel,relatime,data=ordered 0 0

When fsusage scans mtab, it matches on the first entry, but since 'rootfs'
isn't of the expected format '/dev/<blah>' it bails out.

Match early on any rootfs entries and skip them.
Comment 1 Cole Robinson 2013-01-28 17:34:58 UTC 
ping, can someone take a look at this? simple patch that fixes a bug which people are actually hitting:

https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet/issues/97
Comment 2 Jasper Lievisse Adriaanse 2013-01-28 22:00:48 UTC 
Review of attachment 226183 [details] [review]:

Looks good to me.
Comment 3 Jasper Lievisse Adriaanse 2013-01-28 22:04:31 UTC 
Pushed as 37774dc02db47f815d3a3da4e51d91c6d3f4bb16, thank you for the patch.