After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685618 - user-accounts: Recognize that some kerberos domains cannot be joined
user-accounts: Recognize that some kerberos domains cannot be joined
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-10-06 17:02 UTC by Stef Walter
Modified: 2012-10-15 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
user-accounts: Recognize that some kerberos domains cannot be joined (2.51 KB, patch)
2012-10-06 17:02 UTC, Stef Walter 		committed Details | Review
gnome-3-6 patch: user-accounts: Recognize that some kerberos domains cannot be joined (1.75 KB, patch)
2012-10-06 17:04 UTC, Stef Walter 		committed Details | Review

Description Stef Walter 2012-10-06 17:02:46 UTC 
Fix the problem of crashing/precondition failure when user types
a domain like redhat.com or nullroute.eu.org where there is a kerberos
server but we cannot join to it (because it's not AD or IPA).

The first patch contains a new string, and is for gnome-control-conter
3.7.x
Comment 1 Stef Walter 2012-10-06 17:02:48 UTC 
Created attachment 225942 [details] [review]
user-accounts: Recognize that some kerberos domains cannot be joined

realmd supports discovering generic kerberos domains, which cannot
be joined. Add a usable error message in gnome-control-center in
this case.
Comment 2 Stef Walter 2012-10-06 17:04:51 UTC 
Created attachment 225943 [details] [review]
gnome-3-6 patch: user-accounts: Recognize that some kerberos domains cannot be joined

Patch for gnome-3-6 branch without adding another string.
Comment 3 Matthias Clasen 2012-10-09 11:03:06 UTC 
Looks good to me - do we need to bump the required realmd version for this ?
Comment 4 Bastien Nocera 2012-10-09 14:00:48 UTC 
Review of attachment 225943 [details] [review]:

You're not actually adding a usable error message for gnome-3-6 though, are you?
Comment 5 Stef Walter 2012-10-13 12:58:15 UTC 
(In reply to comment #4)
> Review of attachment 225943 [details] [review]:
> 
> You're not actually adding a usable error message for gnome-3-6 though, are
> you?

No. The usable error message is for master.
Comment 6 Bastien Nocera 2012-10-15 09:32:57 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > Review of attachment 225943 [details] [review] [details]:
> > 
> > You're not actually adding a usable error message for gnome-3-6 though, are
> > you?
> 
> No. The usable error message is for master.

Might want to reflect that in the commit message then.
Comment 7 Stef Walter 2012-10-15 12:10:49 UTC 
Attachment 225942 [details] pushed as 074a495 - user-accounts: Recognize that some kerberos domains cannot be joined