GNOME Bugzilla – Bug 685603
Patch to disable static for python modules
Last modified: 2021-07-05 11:01:16 UTC
Created attachment 225926 [details] [review] libxslt-1.1.26-disable_static_modules.patch We are carrying attached patch for a long time downstream on Gentoo due python never trying to use .a files neither .la. Would be nice if it could be accepted by upstream Thanks
Rejected, I sometimes run configure --disable-shared to help build a debugging version and with the patch as-is, compilation fails: make[2]: Entering directory `/home/veillard/XSLT/python' CC libxsltmod_la-libxslt.lo libtool: compile: can not build a shared library libtool: compile: See the libtool documentation for more information. libtool: compile: Fatal configuration error. make[2]: *** [libxsltmod_la-libxslt.lo] Error 1 I guess with some extra massaging to make sure it doesn't break that way and ensure that portability is not affected, then it would be fine. What is the actual problem you are trying to solve, avoid the generation of a .a or force the generation of a shared library even if asked otherwise ? Daniel
Review of attachment 225926 [details] [review]: This break compilation if comfigured with --disable-shared
Python interpreter never tries to import modules from *.a files, so it does not make sense to build libxsltmod.a file. Python bindings of libxslt cannot work without libxsltmod.so, so --disable-shared should disable building of Python bindings (overriding potential --with-python). Please reopen this bug.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/libxslt/-/issues/ Thank you for your understanding and your help.