After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685511 - login-screen: 'Not listed?' is broken
login-screen: 'Not listed?' is broken
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: login-screen
unspecified
Other All
: Normal normal
: ---
Assigned To: Ray Strode [halfline]
gnome-shell-maint
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-10-04 18:25 UTC by Florian Müllner
Modified: 2012-10-04 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
loginDialog: Rely on default button for activation (2.26 KB, patch)
2012-10-04 18:25 UTC, Florian Müllner 		committed Details | Review
modalDialog: Add alternative keys to activate default (1.26 KB, patch)
2012-10-04 18:25 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-10-04 18:25:47 UTC 
The introduction of default buttons on modal dialogs broke the login-screen's
'Not listed?' option - to reproduce:

 (1) Click 'Not listed?'
 (2) Enter username, press Return
 (3) Get an 'Authentification failed' error
     before entering the password

The first patch fixes the issue, the second one is just nice-to-have (although it does fix a regression introduced by the first patch).
Comment 1 Florian Müllner 2012-10-04 18:25:50 UTC 
Created attachment 225836 [details] [review]
loginDialog: Rely on default button for activation

Currently the default action is performed twice when pressing Return
in the login dialog, once in response to the entry's 'activate' signal,
and again by activating the default button. Usually this is not a
problem, as the second invocation is simply ignored, however it breaks
the case where multiple consecutive questions are asked (e.g. username
and password in the 'Not listed' case).
Fix the problem by not handling the 'activate' signal at all.
Comment 2 Florian Müllner 2012-10-04 18:25:53 UTC 
Created attachment 225837 [details] [review]
modalDialog: Add alternative keys to activate default

Currently Return is used to activate the default button of a modal
dialog if no key is specified. It makes sense to allow alternatives
as the keypad's Enter key as well in this case.
Comment 3 Florian Müllner 2012-10-04 18:28:21 UTC 
This clearly needs fixing for 3.6.1.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-04 18:45:23 UTC 
Review of attachment 225836 [details] [review]:

Sure.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-10-04 18:46:57 UTC 
Review of attachment 225837 [details] [review]:

Sure.
Comment 6 Florian Müllner 2012-10-04 19:22:43 UTC 
Attachment 225836 [details] pushed as 20d4ffd - loginDialog: Rely on default button for activation
Attachment 225837 [details] pushed as 55284e4 - modalDialog: Add alternative keys to activate default