After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685444 - unlockDialog: Make the prompt entry insensitive while logging in
unlockDialog: Make the prompt entry insensitive while logging in
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 685443 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-03 20:58 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-10-04 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
unlockDialog: Make the prompt entry insensitive while logging in (2.92 KB, patch)
2012-10-03 20:58 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-10-03 20:58:53 UTC 
See patch.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-03 20:58:55 UTC 
Created attachment 225716 [details] [review]
unlockDialog: Make the prompt entry insensitive while logging in

This ensures that the user can't confusingly edit the entry while
waiting for a response.
Comment 2 Giovanni Campagna 2012-10-03 21:03:58 UTC 
Review of attachment 225716 [details] [review]:

Looks good, but be careful that the styles are shared with the login dialog.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-03 21:14:30 UTC 
*** Bug 685443 has been marked as a duplicate of this bug. ***
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-04 07:04:26 UTC 
Attachment 225716 [details] pushed as 0192a6c - unlockDialog: Make the prompt entry insensitive while logging in


> Looks good, but be careful that the styles are shared with the login dialog.

The login dialog doesn't set the entry (or button) insensitive, which is
another bug. I planned on fixing it, but decided it would probably be more
worthwhile to merge a lot of the codepaths in there, too.

I also wonder if we should do something like this for other passwords, like
NM, Polkit, whatever. Should we have a standard "entry" widget with an entry
and OK/Cancel?

Nah.