After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685441 - this._userVerifier is null
this._userVerifier is null
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
3.5.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-03 20:36 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2012-10-14 16:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ScreenShield: don't allow cancelling the curtain by pressing esc twice in the dialog (1.95 KB, patch)
2012-10-03 21:16 UTC, Giovanni Campagna 		committed Details | Review
UnlockDialog: reset UI on verification failure (1.69 KB, patch)
2012-10-03 21:16 UTC, Giovanni Campagna 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-10-03 20:36:53 UTC 
By pressing escape a bunch on the screen shield, I got a dialog. I entered my password, and:

    JS ERROR: !!!   Exception was: TypeError: this._userVerifier is null
    JS ERROR: !!!     message = '"this._userVerifier is null"'
    JS ERROR: !!!     fileName = '"/home/jstpierre/Source/gnome3/source/gnome-shell/js/gdm/util.js"'
    JS ERROR: !!!     lineNumber = '128'

Putting the shield back down and bringing it back up fixed it.

It also shows my password in the stack trace:

    JS ERROR: !!!     stack = '"("gdm-password","hunter2")@/home/jstpierre/Source/gnome3/source/gnome-shell/js/gdm/util.js:128
wrapper("gdm-password","hunter2")@/home/jstpierre/Source/gnome3/install/share/gjs-1.0/lang.js:204
([object _private_St_IMText])@/home/jstpierre/Source/gnome3/source/gnome-shell/js/ui/unlockDialog.js:263
wrapper([object _private_St_IMText])@/home/jstpierre/Source/gnome3/install/share/gjs-1.0/lang.js:204

We should probably pass a boxed object or something instead so that passwords don't show up.
Comment 1 Giovanni Campagna 2012-10-03 21:16:39 UTC 
Created attachment 225718 [details] [review]
ScreenShield: don't allow cancelling the curtain by pressing esc twice in the dialog

If esc is pressed twice in succession in the unlock dialog, the curtain
is cancelled, but the dialog is cleared after the first esc cancels it,
and it's not destroyed and recreated.
Comment 2 Giovanni Campagna 2012-10-03 21:16:48 UTC 
Created attachment 225719 [details] [review]
UnlockDialog: reset UI on verification failure

When failing verification, reset the UI to the default pre-password
request state, waiting for the next prompt.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-03 21:30:38 UTC 
Review of attachment 225719 [details] [review]:

Could we name this _reset and have _init call it?

Looks fine, otherwise.
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-03 21:30:47 UTC 
Review of attachment 225718 [details] [review]:

Yes.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-10-08 21:38:18 UTC 
Ping on this?
Comment 6 Giovanni Campagna 2012-10-14 16:46:33 UTC 
Ups, I wasn't on CC...
Comment 7 Giovanni Campagna 2012-10-14 16:48:35 UTC 
Attachment 225718 [details] pushed as 5ad7db7 - ScreenShield: don't allow cancelling the curtain by pressing esc twice in the dialog
Attachment 225719 [details] pushed as 99f97ad - UnlockDialog: reset UI on verification failure