After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685342 - Desktop raises without a tray
Desktop raises without a tray
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
: 686048 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-02 22:53 UTC by Carlos Soriano
Modified: 2012-10-12 17:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Don't animate the desktop clone for a failed tray grab (1.64 KB, patch)
2012-10-02 23:25 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Carlos Soriano 2012-10-02 22:53:03 UTC 
To reproduce:

Go to some windows
Push the mouse button (i.e. in the scroll bar to scroll to down)
Go to down with the cursor.
Wait the time out of the message tray to appear.

Then the message tray doens't appear but did the animation and log " JS LOG: pushModal: invocation of begin_modal failed "

The correct behaviour for me is that if some mouse button is pressed, not trigger the message tray.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-02 22:54:54 UTC 
We already make sure not to trigger the tray in that case. The log is harmless, although we could probably invent a flag to suppress it.
Comment 2 Carlos Soriano 2012-10-02 23:02:55 UTC 
The big problem is that the animation is done anyway. So for an instant, all the screen goes up, and half second after(when the animation is done and the modal is failed) the screen goes down again to normality.

So if we already make sure to not trigger the message tray in that...I can't imagine what's going on.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-02 23:25:21 UTC 
Created attachment 225641 [details] [review]
messageTray: Don't animate the desktop clone for a failed tray grab

If we fail to grab for the message tray, we shouldn't be animating
the desktop clone. This is a regression from commit fe124e6.
Comment 4 Carlos Soriano 2012-10-02 23:54:58 UTC 
Thanks Jasper for the patch, I was already fixing it. Your a lot quicker than me =)

Patch tested, works fine.
Comment 5 Giovanni Campagna 2012-10-03 16:17:15 UTC 
Review of attachment 225641 [details] [review]:

Looks good.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-04 07:04:57 UTC 
Attachment 225641 [details] pushed as 7d6c85b - messageTray: Don't animate the desktop clone for a failed tray grab
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-10-12 17:39:06 UTC 
*** Bug 686048 has been marked as a duplicate of this bug. ***