After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685313 - Dragging a launcher from the app view: make the grid button insensitive
Dragging a launcher from the app view: make the grid button insensitive
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-10-02 16:44 UTC by Allan Day
Modified: 2012-10-07 16:21 UTC
See Also:
GNOME target: ---
GNOME version: 3.5/3.6

Attachments
dash: Refactor some common code (3.85 KB, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Clean up unused code (839 bytes, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Make the show apps button insensitive when we're dragging a non-favorite (1.16 KB, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Make the tooltip and hover effect sync up to the real insensitivity (2.13 KB, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Construct the label at init (1.72 KB, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Make the dash items accessible (759 bytes, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
dash: Only set the label's text when initially showing the label (1.48 KB, patch)
2012-10-03 05:24 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Allan Day 2012-10-02 16:44:40 UTC 
If I drag a launcher from the applications view, it looks like I can drop it onto the grid button. What's more, holding the launcher over the grid button reveals a label which says "Remove from Favorites" (even though the app isn't a favorite).

We should make the grid button look insensitive when a drag is initiated from the applications view. We should also make sure that the "Remove from Favorites" label isn't displayed in this situation.
Comment 1 Arnaud B. 2012-10-02 23:44:55 UTC 
In 3.5.92, the problem equally exists for launched applications that are not in favorites (so it’s not “when a drag is initiated from the applications view”).
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:10 UTC 
Created attachment 225659 [details] [review]
dash: Refactor some common code

Take the code that gets an app from a "source" that's duplicated
in lots of spots and refactor it out.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:13 UTC 
Created attachment 225660 [details] [review]
dash: Clean up unused code
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:16 UTC 
Created attachment 225661 [details] [review]
dash: Make the show apps button insensitive when we're dragging a non-favorite

This doesn't handle the tooltip case, unfortunately. That will come in a bit.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:19 UTC 
Created attachment 225662 [details] [review]
dash: Make the tooltip and hover effect sync up to the real insensitivity

We shouldn't display "Remove from Favorites" when dropping on the button
will do nothing.
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:22 UTC 
Created attachment 225663 [details] [review]
dash: Construct the label at init

Nothing doesn't use a label, so it doesn't make sense to
lazily initialize it.
Comment 7 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:25 UTC 
Created attachment 225664 [details] [review]
dash: Make the dash items accessible
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-10-03 05:24:28 UTC 
Created attachment 225665 [details] [review]
dash: Only set the label's text when initially showing the label

Having the tooltip change when it's visible looks strange and glitchy.
This also makes sure that "Remove from Favorites" doesn't change, even
when the user removes their mouse cursor from it.
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-10-03 19:58:59 UTC 
Review for 3.6.1, please?
Comment 10 drago01 2012-10-07 10:04:47 UTC 
Review of attachment 225659 [details] [review]:

Looks good.
Comment 11 drago01 2012-10-07 10:10:48 UTC 
Review of attachment 225660 [details] [review]:

Looks good.
Comment 12 drago01 2012-10-07 10:11:40 UTC 
Review of attachment 225661 [details] [review]:

Looks good.
Comment 13 drago01 2012-10-07 10:14:54 UTC 
Review of attachment 225662 [details] [review]:

Looks good.
Comment 14 drago01 2012-10-07 10:17:17 UTC 
Review of attachment 225663 [details] [review]:

OK.
Comment 15 drago01 2012-10-07 10:17:44 UTC 
Review of attachment 225664 [details] [review]:

Looks good.
Comment 16 drago01 2012-10-07 10:18:37 UTC 
Review of attachment 225665 [details] [review]:

Looks good.
Comment 17 Jasper St. Pierre (not reading bugmail) 2012-10-07 16:21:19 UTC 
Attachment 225659 [details] pushed as 147a6e4 - dash: Refactor some common code
Attachment 225660 [details] pushed as f994ada - dash: Clean up unused code
Attachment 225661 [details] pushed as 52871c7 - dash: Make the show apps button insensitive when we're dragging a non-favorite
Attachment 225662 [details] pushed as 245e43e - dash: Make the tooltip and hover effect sync up to the real insensitivity
Attachment 225663 [details] pushed as 36e5ae4 - dash: Construct the label at init
Attachment 225664 [details] pushed as 06e5c25 - dash: Make the dash items accessible
Attachment 225665 [details] pushed as 6487cd8 - dash: Only set the label's text when initially showing the label