After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685239 - screen locks with modals still up
screen locks with modals still up
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.6.1
: 686513 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-10-01 19:14 UTC by William Jon McCann
Modified: 2012-10-30 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (621.88 KB, image/jpeg)
2012-10-01 19:19 UTC, William Jon McCann
  Details
NetworkAgent: cancel requests when disabling component (1.91 KB, patch)
2012-10-22 21:15 UTC, Giovanni Campagna
none Details | Review
NetworkAgent: cancel requests when disabling component (1.91 KB, patch)
2012-10-22 21:18 UTC, Giovanni Campagna
committed Details | Review

Description William Jon McCann 2012-10-01 19:14:40 UTC
I was testing a new build of the 3.6 live cd and noticed that the screen can lock with a modal dialog showing.

 * Click on a wifi access point that requires a password
 * Don't enter password and walk away
 * Come back after some time and notice that modal is still showing but the screen is locked.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-10-01 19:18:21 UTC
What should we do instead? Cancel any modal dialogs automatically for the user?
Comment 2 William Jon McCann 2012-10-01 19:19:45 UTC
Created attachment 225525 [details]
screenshot
Comment 3 William Jon McCann 2012-10-01 19:35:09 UTC
Maybe the screen lock/shield should always be on top? At least by default.

I suppose cancelling modals might be ok. It would certainly be ok for this particular one.
Comment 4 Matthias Clasen 2012-10-12 01:24:52 UTC
Any idea for a fix here ?
Comment 5 Giovanni Campagna 2012-10-22 21:15:49 UTC
Created attachment 227022 [details] [review]
NetworkAgent: cancel requests when disabling component

When the NetworkAgent is disabled (for example because the lock screen
is being activated), cancel all modal dialogs.
Comment 6 Giovanni Campagna 2012-10-22 21:18:23 UTC
Created attachment 227023 [details] [review]
NetworkAgent: cancel requests when disabling component

When the NetworkAgent is disabled (for example because the lock screen
is being activated), cancel all modal dialogs.
Comment 7 Giovanni Campagna 2012-10-22 21:19:37 UTC
*** Bug 686513 has been marked as a duplicate of this bug. ***
Comment 8 Jasper St. Pierre (not reading bugmail) 2012-10-30 15:33:33 UTC
Review of attachment 227023 [details] [review]:

Sure.
Comment 9 Giovanni Campagna 2012-10-30 15:37:13 UTC
Attachment 227023 [details] pushed as 8819211 - NetworkAgent: cancel requests when disabling component