Bug 685203 – Crash when resuming from sleep

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 685203 - Crash when resuming from sleep


Summary:	Crash when resuming from sleep


Status:	RESOLVED FIXED

Product:	empathy
Classification:	Core
Component:	General
Version:	2.33.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	empathy-maint
QA Contact:	empathy-maint

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2012-10-01 11:51 UTC by Guillaume Desmottes
Modified:	2012-10-02 11:59 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
roster-model-manager: factor out {add_to,remove_from}_top_group_members() (4.42 KB, patch) 2012-10-02 11:49 UTC, Guillaume Desmottes	committed	Details \| Review
individual-manager: make sure the individual stays alive when removing it (1.22 KB, patch) 2012-10-02 11:49 UTC, Guillaume Desmottes	committed	Details \| Review
cope with the top_group_members list being changed while iterating over it (1.77 KB, patch) 2012-10-02 11:49 UTC, Guillaume Desmottes	committed	Details \| Review

Description Guillaume Desmottes 2012-10-01 11:51:33 UTC

+ Trace 230938

#0 g_value_object_collect_value
at gobject.c line 3512
#1 g_signal_emit_valist
at gsignal.c line 3275
#2 g_signal_emit
at gsignal.c line 3356
#3 empathy_roster_model_fire_groups_changed
at empathy-roster-model.c line 88
#4 top_individuals_changed_cb
at empathy-roster-model-manager.c line 193
#5 g_cclosure_marshal_VOID__PARAM
at gmarshal.c line 1042
#6 g_closure_invoke
at gclosure.c line 777
#7 signal_emit_unlocked_R
at gsignal.c line 3551
#8 g_signal_emit_valist
at gsignal.c line 3300
#9 g_signal_emit
at gsignal.c line 3356
#10 g_object_dispatch_properties_changed
at gobject.c line 1041
#11 g_object_notify_by_spec_internal
at gobject.c line 1135
#12 g_object_notify
at gobject.c line 1177
#13 check_top_individuals
at empathy-individual-manager.c line 225
#14 remove_individual
at empathy-individual-manager.c line 293
#15 aggregator_individuals_changed_cb
at empathy-individual-manager.c line 381
#16 g_cclosure_marshal_VOID__OBJECTv
at gmarshal.c line 1312
#17 _g_closure_invoke_va
at gclosure.c line 840
#18 g_signal_emit_valist
at gsignal.c line 3211
#19 g_signal_emit_by_name
at gsignal.c line 3393
#20 _folks_individual_aggregator_emit_individuals_changed
at /home/cassidy/gnome/folks/folks/individual-aggregator.vala line 985
#21 _folks_individual_aggregator_personas_changed_cb
at /home/cassidy/gnome/folks/folks/individual-aggregator.vala line 1505
#22 __folks_individual_aggregator_personas_changed_cb_folks_persona_store_personas_changed
#23 g_cclosure_user_marshal_VOID__OBJECT_OBJECT_STRING_OBJECT_ENUM
at /home/cassidy/gnome/folks/folks/persona-store.vala line 316
#24 g_closure_invoke
at gclosure.c line 777
#25 signal_emit_unlocked_R
at gsignal.c line 3551
#26 g_signal_emit_valist
at gsignal.c line 3300
#27 g_signal_emit_by_name
at gsignal.c line 3393
#28 _folks_persona_store_emit_personas_changed
at /home/cassidy/gnome/folks/folks/persona-store.vala line 439
#29 _tpf_persona_store_contact_list_changed_cb
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 1235
#30 _tpf_persona_store_contact_list_state_changed_cb
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 1175
#31 _tpf_persona_store_notify_connection_cb_async_co
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 861
#32 _tpf_persona_store_notify_connection_cb_async_ready
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 753
#33 g_simple_async_result_complete
at gsimpleasyncresult.c line 775
#34 connection_get_alias_flags_cb
at tp-lowlevel.c line 52
#35 _tp_cli_connection_interface_aliasing_invoke_callback_get_alias_flags
at _gen/tp-cli-connection-body.h line 3698
#36 tp_proxy_pending_call_idle_invoke
at proxy-methods.c line 155
#37 g_idle_dispatch
at gmain.c line 4806
#38 g_main_dispatch
at gmain.c line 2715
#39 g_main_context_dispatch
at gmain.c line 3219
#40 g_main_context_iterate
at gmain.c line 3290
#41 g_main_context_iteration
at gmain.c line 3351
#42 g_application_run
at gapplication.c line 1607
#43 main
at empathy.c line 842

Comment 1 Guillaume Desmottes 2012-10-02 07:58:15 UTC

Full trace with the first warning catched:


(lt-empathy:29235): GLib-GObject-WARNING **: gsignal.c:3281: invalid unclassed object pointer for value type `FolksIndividual'

+ Trace 230943

#0 g_logv
at gmessages.c line 967
#1 g_log
at gmessages.c line 1003
#2 g_signal_emit_valist
at gsignal.c line 3281
#3 g_signal_emit
at gsignal.c line 3356
#4 empathy_roster_model_fire_groups_changed
at empathy-roster-model.c line 88
#5 top_individuals_changed_cb
at empathy-roster-model-manager.c line 193
#6 g_cclosure_marshal_VOID__PARAM
at gmarshal.c line 1042
#7 g_closure_invoke
at gclosure.c line 777
#8 signal_emit_unlocked_R
at gsignal.c line 3551
#9 g_signal_emit_valist
at gsignal.c line 3300
#10 g_signal_emit
at gsignal.c line 3356
#11 g_object_dispatch_properties_changed
at gobject.c line 1041
#12 g_object_notify_by_spec_internal
at gobject.c line 1135
#13 g_object_notify
at gobject.c line 1177
#14 check_top_individuals
at empathy-individual-manager.c line 225
#15 remove_individual
at empathy-individual-manager.c line 293
#16 aggregator_individuals_changed_cb
at empathy-individual-manager.c line 381
#17 g_cclosure_marshal_VOID__OBJECTv
at gmarshal.c line 1312
#18 _g_closure_invoke_va
at gclosure.c line 840
#19 g_signal_emit_valist
at gsignal.c line 3211
#20 g_signal_emit_by_name
at gsignal.c line 3393
#21 _folks_individual_aggregator_emit_individuals_changed
at /home/cassidy/gnome/folks/folks/individual-aggregator.vala line 985
#22 _folks_individual_aggregator_personas_changed_cb
at /home/cassidy/gnome/folks/folks/individual-aggregator.vala line 1505
#23 __folks_individual_aggregator_personas_changed_cb_folks_persona_store_personas_changed
at /home/cassidy/gnome/folks/folks/individual-aggregator.vala line 809
#24 g_cclosure_user_marshal_VOID__OBJECT_OBJECT_STRING_OBJECT_ENUM
at /home/cassidy/gnome/folks/folks/persona-store.vala line 316
#25 g_closure_invoke
at gclosure.c line 777
#26 signal_emit_unlocked_R
at gsignal.c line 3551
#27 g_signal_emit_valist
at gsignal.c line 3300
#28 g_signal_emit_by_name
at gsignal.c line 3393
#29 _folks_persona_store_emit_personas_changed
at /home/cassidy/gnome/folks/folks/persona-store.vala line 439
#30 _tpf_persona_store_contact_list_changed_cb
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 1235
#31 _tpf_persona_store_contact_list_state_changed_cb
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 1175
#32 _tpf_persona_store_notify_connection_cb_async_co
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 861
#33 _tpf_persona_store_notify_connection_cb_async_ready
at /home/cassidy/gnome/folks/backends/telepathy/lib/tpf-persona-store.vala line 753
#34 g_simple_async_result_complete
at gsimpleasyncresult.c line 775
#35 connection_get_alias_flags_cb
at tp-lowlevel.c line 52
#36 _tp_cli_connection_interface_aliasing_invoke_callback_get_alias_flags
at _gen/tp-cli-connection-body.h line 3698
#37 tp_proxy_pending_call_idle_invoke
at proxy-methods.c line 155
#38 g_idle_dispatch
#39 g_main_dispatch
at gmain.c line 2715
#40 g_main_context_dispatch
at gmain.c line 3219
#41 g_main_context_iterate
at gmain.c line 3290
#42 g_main_context_iteration
at gmain.c line 3351
#43 g_application_run
at gapplication.c line 1620
#44 main
at empathy.c line 842

Comment 2 Guillaume Desmottes 2012-10-02 11:49:12 UTC

Created attachment 225574 [details] [review]
roster-model-manager: factor out {add_to,remove_from}_top_group_members()

Comment 3 Guillaume Desmottes 2012-10-02 11:49:15 UTC

Created attachment 225575 [details] [review]
individual-manager: make sure the individual stays alive when removing it

Comment 4 Guillaume Desmottes 2012-10-02 11:49:18 UTC

Created attachment 225576 [details] [review]
cope with the top_group_members list being changed while iterating over it

Comment 5 Xavier Claessens 2012-10-02 11:58:23 UTC

+1

Comment 6 Guillaume Desmottes 2012-10-02 11:58:55 UTC

Attachment 225574 [details] pushed as 33b5753 - roster-model-manager: factor out {add_to,remove_from}_top_group_members()
Attachment 225575 [details] pushed as f72a036 - individual-manager: make sure the individual stays alive when removing it
Attachment 225576 [details] pushed as ee2b89a - cope with the top_group_members list being changed while iterating over it