After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 685120 - Pressing ESC does not close the search bar if it is not focused
Pressing ESC does not close the search bar if it is not focused
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Search Interface
3.26.x
Other Linux
: Normal normal
: 3.26
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 741700 753557 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-09-30 06:56 UTC by Juan Antonio
Modified: 2017-08-23 14:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window-slot: hide search bar on ESC presses (1.19 KB, patch)
2017-08-23 13:13 UTC, Ernestas Kulik 		committed Details | Review

Description Juan Antonio 2012-09-30 06:56:02 UTC 
I search anything, then click on file panel or lateral panel, I think I should be press escape to close search bar but it`s not, I have to click on search bar and then press escape.
Comment 1 Cosimo Cecchi 2014-12-22 01:26:19 UTC 
*** Bug 741700 has been marked as a duplicate of this bug. ***
Comment 2 Jason Siefken 2017-05-01 20:57:51 UTC 
This is a regression from 3.16.
Comment 3 Jason Siefken 2017-05-01 20:59:27 UTC 
In 3.16, pressing escape while the search field was open even when a file was in focus would change the search field.  Now, in 3.22, pressing escape won't close the search field if it is out of focus.
Comment 4 António Fernandes 2017-08-23 11:07:01 UTC 
*** Bug 753557 has been marked as a duplicate of this bug. ***
Comment 5 Ernestas Kulik 2017-08-23 13:13:40 UTC 
Created attachment 358233 [details] [review]
window-slot: hide search bar on ESC presses

This supposedly regressed after some version of Nautilus.
Comment 6 Carlos Soriano 2017-08-23 13:28:10 UTC 
Review of attachment 358233 [details] [review]:

LGTM
Comment 7 António Fernandes 2017-08-23 13:39:23 UTC 
Hitting [Esc] after selecting a search result was part of a workflow intended to replace type-ahead, such that selecting a file on search and hitting ESC would reveal the selected file in the folder. See commit 1594c2b03e98d59dfb8dcd4a62fd56ff2f6025aa

I've tested the patch above and it successfully restores that behavior. Thanks Ernestas!
Comment 8 Ernestas Kulik 2017-08-23 14:10:07 UTC 
Attachment 358233 [details] pushed as 3bed0e6 - window-slot: hide search bar on ESC presses