After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684942 - asfdemux: First buffers are 0-sized on some files
asfdemux: First buffers are 0-sized on some files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal major
: 1.2.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-27 10:25 UTC by Sebastian Dröge (slomo)
Modified: 2013-11-09 09:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
asfdemux: really copy the buffer data (1.17 KB, patch)
2013-10-22 04:18 UTC, Thiago Sousa Santos
committed Details | Review
asfdemux: Keep audio error checking fields only for audio (5.01 KB, patch)
2013-10-22 18:24 UTC, Thiago Sousa Santos
committed Details | Review

Description Sebastian Dröge (slomo) 2012-09-27 10:25:51 UTC
http://samples.mplayerhq.hu/asf-wmv/Saolin.audio_0x75-VoxwareMetaSound.V4CC_MP42.asf

Has the problem that the first buffer that contains real data is not marked as keyframe, and confuses gst-libav then.
Comment 1 Thiago Sousa Santos 2013-10-22 04:18:27 UTC
Created attachment 257812 [details] [review]
asfdemux: really copy the buffer data

Add missing flag to make the buffer descrambling really copy the data.
Still the keyframes still seem to be missing something and will show up
badly during playback.

https://bugzilla.gnome.org/show_bug.cgi?id=684842
Comment 2 Thiago Sousa Santos 2013-10-22 18:24:54 UTC
Created attachment 257868 [details] [review]
asfdemux: Keep audio error checking fields only for audio

Fix an issue where the descrambling code was being used for video and not
only for audio. This makes this media's video show correctly.
Comment 3 Thiago Sousa Santos 2013-10-22 19:25:08 UTC
commit 3de558d96bb9230ada7297074ded1ebda6c4a026
Author: Thiago Santos <ts.santos@partner.samsung.com>
Date:   Tue Oct 22 15:03:15 2013 -0300

    asfdemux: Keep audio error checking fields only for audio
    
    Video shouldn't need to be descrambled, this can cause frames data
    to be corrupted
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684942

commit 94a183a071a53a808857ccc3ff6687bc09f1b183
Author: Thiago Santos <ts.santos@partner.samsung.com>
Date:   Tue Oct 22 00:56:29 2013 -0300

    asfdemux: really copy the buffer data
    
    Pass the copy-memory flag to copy the memory for the output buffer,
    otherwise we end with 0-sized buffers
    
    https://bugzilla.gnome.org/show_bug.cgi?id=684942
Comment 4 Thiago Sousa Santos 2013-10-22 19:25:48 UTC
Comment on attachment 257868 [details] [review]
asfdemux: Keep audio error checking fields only for audio

Improved a few things, but the basis of the patch is the same, so marking as committed.