After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684864 - Unable to remove language: Minus button always greyed out
Unable to remove language: Minus button always greyed out
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
3.6.1
Depends on:
Blocks:
 
 
Reported: 2012-09-26 11:43 UTC by Prathibha
Modified: 2012-10-01 09:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
region: Remove dead button (1.92 KB, patch)
2012-09-27 10:44 UTC, Bastien Nocera
committed Details | Review

Description Prathibha 2012-09-26 11:43:05 UTC
In System Settings -> Region & Language, Language tab, '-' remove language button is always disabled. Because of this it is not possible to remove the added language.
Comment 1 Bastien Nocera 2012-09-27 10:44:27 UTC
Created attachment 225251 [details] [review]
region: Remove dead button

The button hasn't ever been hooked to anything. Let's remove it.
Comment 2 Bastien Nocera 2012-09-27 10:50:38 UTC
Sent a mail to gnome-doc-list about removing the button altogether.
Comment 3 Parag AN 2012-09-27 11:28:24 UTC
Is this also part of design document to remove language button?
Comment 4 Jeremy Bicha 2012-09-27 12:44:40 UTC
Wouldn't it be better to fix the button?
Comment 5 Bastien Nocera 2012-09-27 12:55:19 UTC
(In reply to comment #4)
> Wouldn't it be better to fix the button?

Fix the button to do what exactly? The list of languages is made of 1) popular languages, 2) other users' selected languages, 3) your current language. You can't "remove" those.
Comment 6 Bastien Nocera 2012-09-27 12:55:57 UTC
(In reply to comment #3)
> Is this also part of design document to remove language button?

Of what design document? I don't understand the question here.
Comment 7 André Klapper 2012-09-27 13:03:31 UTC
(In reply to comment #5)
> Fix the button to do what exactly? The list of languages is made of 1) popular
> languages, 2) other users' selected languages, 3) your current language. You
> can't "remove" those.

If I can add a language here myself in this dialogue, why shouldn't I be able to remove it again? Why shouldn't I be able to remove "popular languages" that I'm never going to need?
Comment 8 Parag AN 2012-09-27 13:18:29 UTC
that is right. Why would people need to see unnecessary languages there? But, if the popular languages list is upto 3 or max 5 languages its ok. But still I think language removal option should be given. What if a user mistakenly added language and don't want it to be appeared there?
Comment 9 Bastien Nocera 2012-09-27 14:18:47 UTC
(In reply to comment #8)
> that is right. Why would people need to see unnecessary languages there? But,
> if the popular languages list is upto 3 or max 5 languages its ok. But still I
> think language removal option should be given. What if a user mistakenly added
> language and don't want it to be appeared there?

Make sure it's not selected. The next time you start the panel it won't be there because it's not a language in either of the 3 lists I mentioned above. Apart from pleasing  people that want it to be tidied before closing the window, I really don't see the point.
Comment 10 André Klapper 2012-09-27 14:23:40 UTC
Didn't know that, thanks. Remaining question: Why can't I remove popular languages that I'm never going to use?
Comment 11 Bastien Nocera 2012-09-27 14:30:10 UTC
(In reply to comment #10)
> Didn't know that, thanks. Remaining question: Why can't I remove popular
> languages that I'm never going to use?

Why should you, really?
Comment 12 André Klapper 2012-09-27 15:20:35 UTC
(In reply to comment #11)
> Why should you, really?

Why do you put eight languages there in the first place if I will never need them? Just to clutter the list of my language preferences?
Comment 13 Bastien Nocera 2012-09-27 15:24:30 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > Why should you, really?
> 
> Why do you put eight languages there in the first place if I will never need
> them? Just to clutter the list of my language preferences?

Because they're useful to the majority of people.
Comment 14 André Klapper 2012-09-27 15:29:01 UTC
Yeah, but obviously not to me. Which brings us back to comment 10 that you haven't answered yet.
Comment 15 Bastien Nocera 2012-09-27 15:31:34 UTC
(In reply to comment #14)
> Yeah, but obviously not to me. Which brings us back to comment 10 that you
> haven't answered yet.

And it's not what this bug is about. You haven't answered why it's a problem that there's a short list of very influential languages in this list. In fact, I don't care about the answer because in the future that default list would be based on physical location.

Can we move on from the inquisition? It's really not helpful.
Comment 16 André Klapper 2012-09-27 15:39:55 UTC
> (In reply to comment #14)
> And it's not what this bug is about. 

My question "Why can't I remove popular languages that I'm never going to use?" and the subject "Unable to remove language" in combination with removing the [non-working] option to remove languages looks like what this ticket is about.

> You haven't answered why it's a problem
> that there's a short list of very influential languages in this list.

True, but I didn't start with posting counterquestions to avoid giving answers either.

> I don't care about the answer because in the future that default list would be
> based on physical location.

Having mentioned this earlier would have saved my time too. 
You should know better how to communicate, Bastien.
Comment 17 Matthias Clasen 2012-09-28 16:06:33 UTC
To comment here as the one who wrote the initial code:

The idea was that the minus button would allow you to remove languages that you've added with +, but not the 'builtin' language.

Obviously, that's not what the button does today. And it is probably fine (and much more straightforward) to just allow removing any language, as long as we make sure that all the removed ones reappear in the add dialog.
Comment 18 Bastien Nocera 2012-10-01 09:39:18 UTC
Attachment 225251 [details] pushed as 9dcf8cb - region: Remove dead button