After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684611 - volume: Fix initial visibility of input
volume: Fix initial visibility of input
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-22 07:49 UTC by Florian Müllner
Modified: 2012-09-25 11:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
volume: Fix initial visibility of input (1.23 KB, patch)
2012-09-22 07:49 UTC, Florian Müllner 		reviewed Details | Review
volume: Fix initial visibility of input (1.49 KB, patch)
2012-09-22 12:07 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-09-22 07:49:02 UTC 
See patch.
Comment 1 Florian Müllner 2012-09-22 07:49:05 UTC 
Created attachment 224970 [details] [review]
volume: Fix initial visibility of input

Currently the visibility of input volume is only updated when a stream
is added/removed - apparently no one noticed until now, as in the normal
user session we get away with this as long as we have some startup sound,
but this is not the case in the lock screen, so we may end up showing
input volume incorrectly.
Comment 2 Colin Walters 2012-09-22 08:31:53 UTC 
Review of attachment 224970 [details] [review]:

I don't know this code at all, but a cursory inspection makes it feel to me like changing VolumeMenu._init() to just call _onControlStateChanged(), and then doing this call inside there would be better?
Comment 3 Florian Müllner 2012-09-22 12:07:03 UTC 
Created attachment 224972 [details] [review]
volume: Fix initial visibility of input

Fine by me ...
Comment 4 Colin Walters 2012-09-24 20:40:05 UTC 
Review of attachment 224972 [details] [review]:

This looks cleaner to me.
Comment 5 Matthias Clasen 2012-09-24 20:42:17 UTC 
Freeze break approval 1 for the release team, from me
Comment 6 André Klapper 2012-09-25 10:57:35 UTC 
r-t approval 2 of 2. Please commit.
Comment 7 Florian Müllner 2012-09-25 11:00:14 UTC 
Attachment 224972 [details] pushed as 908bf3b - volume: Fix initial visibility of input