After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684536 - Get rid of ProcData structure
Get rid of ProcData structure
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-21 09:44 UTC by Stefano Facchini
Modified: 2012-10-03 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Get rid of ProcData structure (137.77 KB, patch)
2012-09-21 09:44 UTC, Stefano Facchini 		needs-work Details | Review
Get rid of ProcData structure (138.94 KB, patch)
2012-10-02 09:36 UTC, Stefano Facchini 		none Details | Review

Description Stefano Facchini 2012-09-21 09:44:21 UTC 
Some cleanup after the GtkApplication/Appmenu rework
Comment 1 Stefano Facchini 2012-09-21 09:44:24 UTC 
Created attachment 224913 [details] [review]
Get rid of ProcData structure

It's redundant now that we have a true Application object
Comment 2 Robert Roth 2012-09-30 20:52:21 UTC 
Review of attachment 224913 [details] [review]:

I like the idea of the cleanup, however the patch has lots of rejected chunks when applied for the current master. Could you please update it to apply cleanly?
Comment 3 Stefano Facchini 2012-10-02 09:36:49 UTC 
Created attachment 225567 [details] [review]
Get rid of ProcData structure

It's redundant now that we have a true Application object



Hi Robert, here is the patch rebased on master.
Comment 4 Robert Roth 2012-10-03 15:44:22 UTC 
Thanks for the quick response. Had to fix a minor issue with something introduced since you have proposed the first patch (set maximized state on startup : replace app->main_window with main_window - to make it work again) but it's OK otherwise. I have committed it to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.