After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684492 - can't set a password for a passwordless user
can't set a password for a passwordless user
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-20 16:58 UTC by Matthias Clasen
Modified: 2012-09-24 19:51 UTC
See Also:
GNOME target: 3.6
GNOME version: ---


Attachments
users: Don't ask for the old password when none is set (2.19 KB, patch)
2012-09-22 18:08 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2012-09-20 16:58:36 UTC
I was on a live cd, so my user didn't have a password.
The user panel correctly says 'None' for the password. 
But when I try to enter a new password in the dialog (leaving the 'old password' field blank),  the 'change'  button never goes sensitive. We are not supposed to show the 'old password' field in this case anyway.
Comment 1 Bastien Nocera 2012-09-20 19:31:53 UTC
Ondrej, want to look into that?
Comment 2 Matthias Clasen 2012-09-22 18:08:56 UTC
Created attachment 224990 [details] [review]
users: Don't ask for the old password when none is set

This prevents passwordless users (common on live cd setups) from
setting a password.
Comment 3 Bastien Nocera 2012-09-24 14:34:43 UTC
Review of attachment 224990 [details] [review]:

Looks fine to me.
Comment 4 Colin Walters 2012-09-24 15:44:01 UTC
Should we be handling UM_PASSWORD_MODE_ENABLED too?
Comment 5 Matthias Clasen 2012-09-24 16:04:30 UTC
I don't think it applies to UM_PASSWORD_MODE_ENABLED, really.
The mode is enabled only if you re-eanble a previously disable (ie locked) account. In that case, you don't get the old password field.
Comment 6 Matthias Clasen 2012-09-24 16:32:38 UTC
Those modes are a bit iffy, since we map them to a smaller set + a boolean in the accountsservice (regular/set-at-login/none, plus a locked boolean)
Comment 7 Matthias Clasen 2012-09-24 17:24:00 UTC
Fixing that iffiness will come as a side-effect of porting to libaccountsservice, I think.
Comment 8 Matthias Clasen 2012-09-24 19:50:58 UTC
Attachment 224990 [details] pushed as a80b3d7 - users: Don't ask for the old password when none is set