GNOME Bugzilla – Bug 684402
[0.11] Can't access GstPadProbeInfo data pointer from introspection
Last modified: 2012-09-20 19:26:58 UTC
The introspection can't use the macros to cast the GstPadProbeInfo. I'll attach a patch that adds functions that do the same thing.
Created attachment 224778 [details] [review] pad: Add functions to safely access GstProbeInfo data pointer
<__tim> I guess the other alternative was to do a (named) union? <__tim> The functions are fine with me, but will it work with bindings like that? Do we also need to register the probe info struct as boxed type? <__tim> And they also need adding to the -sections.txt file in docs and the .def file (make check-exports in top-level) <__tim> and could you align the function names and argument please (with spaces) :) <__tim> in the header file <__tim> oh, also: shouldn't the first checks for the type be g_return_val_if_fail() ? <__tim> do you think it's useful to handle it gracefully? (not that I think it makes a difference, just can't imagine a case where it's not likely to be a programming error)
Created attachment 224781 [details] [review] pad: Add functions to safely access GstProbeInfo data pointer I tested with pygi, there is seems to work fine. other points addressed in this updated patch
Comment on attachment 224781 [details] [review] pad: Add functions to safely access GstProbeInfo data pointer Looks good to me. Two more tiny nitpicks: could you mention in the commit message that this is for bindings/g-i. And in the docs, the "Returns:" should probably no longer have an allow-none annotation?
Created attachment 224783 [details] [review] pad: Add functions to safely access GstProbeInfo data pointer This is so that introspection based bindings can access it.
commit 25b3e02b94df664423c0a23e34829af75f9be0c4 Author: Olivier Crête <olivier.crete@collabora.com> Date: Wed Sep 19 15:01:46 2012 -0400 pad: Add functions to safely access GstProbeInfo data pointer This is so that introspection based bindings can access it. https://bugzilla.gnome.org/show_bug.cgi?id=684402