After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684384 - Wireless passphrase and lock-screen
Wireless passphrase and lock-screen
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: lock-screen
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-19 16:01 UTC by David Zeuthen (not reading bugmail)
Modified: 2012-09-20 21:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Photo (412.28 KB, image/jpeg)
2012-09-19 16:03 UTC, David Zeuthen (not reading bugmail) 		  Details
Don't show network dialogs in the lock screen (1.23 KB, patch)
2012-09-20 06:54 UTC, Giovanni Campagna 		committed Details | Review

Description David Zeuthen (not reading bugmail) 2012-09-19 16:01:05 UTC 
When I opened my laptop in the office this morning, a popup asking for the Wifi password for 'davidznet' covered the lock screen, see attached photo

There are several problems here

 - I don't think it's a good idea to ever show such dialogs on the lock screen

 - davidznet is my Wifi network at home (e.g. not in range)
   - (this may be a NetworkManager problem, not a gnome-shell problem)

 - after unlocking, there was a GTK+-based dialog asking for the same passphrase...

This is with the gnome-shell-3.5.91-1.fc18.x86_64 packages on f18.
Comment 1 David Zeuthen (not reading bugmail) 2012-09-19 16:03:41 UTC 
Created attachment 224766 [details]
Photo
Comment 2 Giovanni Campagna 2012-09-20 06:54:04 UTC 
Created attachment 224809 [details] [review]
Don't show network dialogs in the lock screen

Remove the network agent component from the lock screen and unlock
dialog session modes.
Comment 3 drago01 2012-09-20 07:27:06 UTC 
Review of attachment 224809 [details] [review]:

Looks good, fine to to commit with RT approval.
Comment 4 Giovanni Campagna 2012-09-20 17:16:58 UTC 
I'm not at home right now, and can barely keep up with mail.
Could please someone else take care of this?
Thank you!
Comment 5 Matthias Clasen 2012-09-20 17:55:58 UTC 
release team approval 1 of 2
Comment 6 André Klapper 2012-09-20 18:01:12 UTC 
release team approval 2 of 2
Comment 7 drago01 2012-09-20 18:03:24 UTC 
Attachment 224809 [details] pushed as 0ff614c - Don't show network dialogs in the lock screen
Comment 8 Colin Walters 2012-09-20 18:05:13 UTC 
So I had to look at the infrastructure behind this patch to convince myself it works, but it appears it will.  It's actually pretty nice and clean code.  Kudos to the authors =)

So RT 2/2
Comment 9 Jasper St. Pierre (not reading bugmail) 2012-09-20 21:14:48 UTC 
You told me to add the network agent, Giovanni!