After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683613 - No short code in the status indicator for some input sources
No short code in the status indicator for some input sources
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-08 10:20 UTC by Mathieu Bridon
Modified: 2012-09-12 16:57 UTC
See Also:
GNOME target: 3.6
GNOME version: ---


Attachments
Empty status icon for quick 3 (114.03 KB, image/png)
2012-09-08 10:22 UTC, Mathieu Bridon
  Details
No short code for multiple input sources (127.43 KB, image/png)
2012-09-08 10:26 UTC, Mathieu Bridon
  Details
status/keyboard: Handle IBus engines which don't specify a symbol (1.79 KB, patch)
2012-09-09 20:49 UTC, Rui Matos
committed Details | Review

Description Mathieu Bridon 2012-09-08 10:20:13 UTC
I'm currently testing the input methods used in Hong Kong, which were recently added:
    https://bugzilla.gnome.org/show_bug.cgi?id=682313#c30

None of these get a short code displayed in the input source status icon/menu.

I'll attach screenshots showing the problem.
Comment 1 Mathieu Bridon 2012-09-08 10:22:59 UTC
Created attachment 223803 [details]
Empty status icon for quick 3

This is what I get when I select the quick3 input source.

Notice how there is an empty space between the a11y and sound status icons.

That's where the input source status icon should be, with a short code representing the chosen input source (something like "cn", "zh", or a chinese character).
Comment 2 Mathieu Bridon 2012-09-08 10:26:42 UTC
Created attachment 223804 [details]
No short code for multiple input sources

This is what I get when I add quick3, quick5, cangjie3, cangjie5 and stroke5.

Notice how for the French layout I have the "fr" short code, but for the Chinese input methods I only get an integer.

It seems as if GNOME Shell knows that they are all Chinese, so it displays the same short code (nothing), then appends an integer to differentiate them.

The short code is missing though.
Comment 3 Rui Matos 2012-09-09 13:18:29 UTC
The fix should be done in ibus-table to include a meaningful <symbol> tag on the engine descriptions.

On our side, I can add a fall back to use the 2 or 3 characters language code or, failing that (there are some really crappy engines out there...), use an hard coded generic symbol.

Patch coming.
Comment 4 Rui Matos 2012-09-09 20:49:34 UTC
Created attachment 223862 [details] [review]
status/keyboard: Handle IBus engines which don't specify a symbol

In this case, fall back to the 2 or 3 letter language code or, failing
that, to a keyboard symbol.
Comment 5 Florian Müllner 2012-09-11 15:30:19 UTC
Review of attachment 223862 [details] [review]:

Yeah, I guess that's the best we can do (in gnome-shell). Looks good.
Comment 6 Rui Matos 2012-09-12 16:57:17 UTC
Attachment 223862 [details] pushed as 409af28 - status/keyboard: Handle IBus engines which don't specify a symbol