GNOME Bugzilla – Bug 683506
remove places and devices section
Last modified: 2012-09-16 17:03:37 UTC
We still have a Places & Devices section in the search results. Now that we have nautilus search in addition to Documents search it is just too much to also have the Places stuff.
Created attachment 223663 [details] [review] ViewSelector: remove the places & devices search provider Remove the PlacesManager, its search provider and all associated code. Places search is now provided by nautilus using the external search provider API. This is the invasive version. It's a good cleanup and removes unneeded stuff from the compositor main loop, but it breaks extensions relying on it (I have two...)
Review of attachment 223663 [details] [review]: Untested, but looks good anyway; my only worry would be if external mounts actually show up in nautilus search results (they didn't last time I checked), not breaking extensions - IMHO it's the price extension authors have to pay for having access to everything rather than a selected API ...
I've seen some passing by commits to extend the nautilus search provider to show "places", but it doesn't work here, so I'm putting this on hold for now. William, can you update the bug when it's implemented in Nautilus? Thank you!
Giovanni: XDG folders should all be returned as part of the nautilus results, and it works fine here. External mounts are not returned right now, but I think we could easily add that to the Nautilus search provider if it's desired.
Well, if we remove places&devices in favour of nautilus, but nautilus doesn't include devices or remote mounts it would be a regression, I think.
(In reply to comment #6) > Well, if we remove places&devices in favour of nautilus, but nautilus doesn't > include devices or remote mounts it would be a regression, I think. I'll update the Nautilus search provider to include those then, and update the status of this bug when it's implemented.
(In reply to comment #7) > I'll update the Nautilus search provider to include those then, and update the > status of this bug when it's implemented. This is now implemented on the Nautilus side.
(In reply to comment #8) > (In reply to comment #7) > > > I'll update the Nautilus search provider to include those then, and update the > > status of this bug when it's implemented. > > This is now implemented on the Nautilus side. Thank you! I sent a heads up to r-t and docs, and then I'll proceed with the removal on the shell side.
Attachment 223663 [details] pushed as f39098a - ViewSelector: remove the places & devices search provider