After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683438 - autorunManager: Don't show a right-click menu
autorunManager: Don't show a right-click menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-05 17:01 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-05-24 19:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: Split out the building of the right menu to a separate method (6.43 KB, patch)
2012-09-05 17:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
autorunManager: Don't show a right-click menu (1.96 KB, patch)
2012-09-05 17:01 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-09-05 17:01:19 UTC 
It clearly makes no sense for a resident source.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-09-05 17:01:21 UTC 
Created attachment 223564 [details] [review]
messageTray: Split out the building of the right menu to a separate method

Besides code cleanliness, this allows us to stub out a right-click menu
for resident sources.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-09-05 17:01:24 UTC 
Created attachment 223565 [details] [review]
autorunManager: Don't show a right-click menu

Activating the source shouldn't be possible, and neither should
removing it.
Comment 3 Giovanni Campagna 2012-09-05 17:09:08 UTC 
Review of attachment 223565 [details] [review]:

Ok
Comment 4 Giovanni Campagna 2012-09-05 17:29:01 UTC 
Review of attachment 223564 [details] [review]:

Yes

::: js/ui/messageTray.js
@@ +1066,3 @@
+        let item;
+        let rightClickMenu = new St.BoxLayout({ name: 'summary-right-click-menu',
+                                                vertical: true });

At some point we really need to put a PopupMenuBase here, especially if we start using complex menus.
I had a patch for a PopupMenuEmbed, back in the days of appindicator. Maybe I can recover it...
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-09-13 18:46:02 UTC 
Attachment 223564 [details] pushed as 6f5b700 - messageTray: Split out the building of the right menu to a separate method
Attachment 223565 [details] pushed as e71129a - autorunManager: Don't show a right-click menu