After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683429 - 3.5.90: Couldn't load the '/usr/share/totem/mozilla-viewer.ui' interface. Invalid object type 'TotemGlowButton'.
3.5.90: Couldn't load the '/usr/share/totem/mozilla-viewer.ui' interface. Inv...
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
3.5.x
Other All
: Normal critical
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on:
Blocks:
 
 
Reported: 2012-09-05 15:28 UTC by Olav Vitters
Modified: 2012-09-13 21:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
browser-plugin: force registration of TotemGlowButton type (#683429) (1.01 KB, patch)
2012-09-06 19:51 UTC, Olivier Blin
none Details | Review
browser-plugin: init g_type (759 bytes, patch)
2012-09-07 17:50 UTC, Olivier Blin
rejected Details | Review
browser-plugin: ensure that types required by ui files are registered (796 bytes, patch)
2012-09-07 17:50 UTC, Olivier Blin
committed Details | Review
browser-plugin: really use GtkMenuButton (846 bytes, patch)
2012-09-07 17:50 UTC, Olivier Blin
committed Details | Review

Description Olav Vitters 2012-09-05 15:28:49 UTC
Report by Mageia users. Could be a packaging problem, or maybe those gobject-introspection changes?

Error message shown by totem-mozilla plugin:
Couldn't load the '/usr/share/totem/mozilla-viewer.ui' interface.
Invalid object type 'TotemGlowButton'.


Original bugreport:
https://bugs.mageia.org/show_bug.cgi?id=7359

Screenshot:
https://bugs.mageia.org/attachment.cgi?id=2753
Comment 1 Bastien Nocera 2012-09-05 15:42:54 UTC
Looks like your linker is trimming the glow button widget from the totem-plugin-viewer binary. You'll probably want to review your linker flags.
Comment 2 Olivier Blin 2012-09-06 19:51:46 UTC
Created attachment 223698 [details] [review]
browser-plugin: force registration of TotemGlowButton type (#683429)

This patch fixes the issue, by make sure the TotemGlowButton type is registered.
Else, nothing seems to call the registration function (generated inside totem_glow_button_get_type).

This is not a linker issue, the TotemGlowButton symbols are correctly present as global symbols in the binary.
Comment 3 Olivier Blin 2012-09-07 13:05:16 UTC
Actually, this patch is not enough, I'll post a new version.
Comment 4 Olivier Blin 2012-09-07 17:50:02 UTC
Created attachment 223781 [details] [review]
browser-plugin: init g_type
Comment 5 Olivier Blin 2012-09-07 17:50:17 UTC
Created attachment 223782 [details] [review]
browser-plugin: ensure that types required by ui files are registered
Comment 6 Olivier Blin 2012-09-07 17:50:40 UTC
Created attachment 223783 [details] [review]
browser-plugin: really use GtkMenuButton
Comment 7 Olivier Blin 2012-09-07 17:52:30 UTC
These 3 patches are needed to make totem-plugin-work on Mageia Cauldron.
For the record, we are currently using glib 2.33.12 and gtk 3.5.16.
Comment 8 Olivier Blin 2012-09-07 17:53:32 UTC
Without the third patch, it's quite unlikely that totem-plugin-viewer could be loaded properly, with any glib/gtk version.
Comment 9 Bastien Nocera 2012-09-13 15:23:28 UTC
Review of attachment 223783 [details] [review]:

++
Comment 10 Bastien Nocera 2012-09-13 15:23:58 UTC
Review of attachment 223782 [details] [review]:

++
Comment 11 Bastien Nocera 2012-09-13 15:26:03 UTC
Review of attachment 223781 [details] [review]:

We've already got a call to that, through the option parsing:
g_option_context_add_group (context, gtk_get_option_group (TRUE));
Comment 12 Bastien Nocera 2012-09-13 15:28:41 UTC
Review of attachment 223782 [details] [review]:

This obviously needs to be called after the option parsing has been done.
Comment 13 Bastien Nocera 2012-09-13 16:03:57 UTC
Attachment 223783 [details] pushed as 94d397f - browser-plugin: really use GtkMenuButton
Comment 14 Olivier Blin 2012-09-13 21:28:31 UTC
Confirming that your version of attachment 223782 [details] [review] fixes the issue as well, without attachment 223781 [details] [review]
Thanks for your review!