After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 683420 - Update COPYING to be GPLv3+
Update COPYING to be GPLv3+
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-05 13:55 UTC by Colin Walters
Modified: 2016-09-12 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update COPYING to be GPLv3+ (51.49 KB, patch)
2012-09-05 13:56 UTC, Colin Walters
none Details | Review
switch all my files to gplv2+ (18.77 KB, patch)
2012-09-06 11:53 UTC, Matthias Clasen
committed Details | Review
Use GPLv2+ for files created by Marek Kasik (14.57 KB, patch)
2012-09-06 13:57 UTC, Marek Kašík
committed Details | Review
user-accounts: Relicense UmRealmManager to GPLv2+ (2.04 KB, patch)
2012-09-17 08:43 UTC, Stef Walter
committed Details | Review

Description Colin Walters 2012-09-05 13:55:59 UTC
Several commits in this module have introduced GPLv3+ code:

930540ea283b46bf4f96ea18fc97ec108c562374
3fb4d4af2745124c3d370c0fcc94fdb5886af245
27c45abda3294239c7881a2ad878d9d1443f099a

Ideally, we'd relicense back to GPLv2+, but for now, update COPYING to
reflect reality.
Comment 1 Colin Walters 2012-09-05 13:56:00 UTC
Created attachment 223539 [details] [review]
Update COPYING to be GPLv3+
Comment 2 Bastien Nocera 2012-09-05 14:06:25 UTC
Both of those commits are Matthias' code, and one from Marek. My guess is that they used the boilerplate code.
Comment 3 Colin Walters 2012-09-05 17:43:01 UTC
(In reply to comment #2)
> Both of those commits are Matthias' code, and one from Marek. My guess is that
> they used the boilerplate code.

Are you saying then we should try to revert back to GPLv2?  That makes sense to me, but we shouldn't leave g-c-c in a state where the COPYING file is wrong for too long either.
Comment 4 Bastien Nocera 2012-09-05 17:45:40 UTC
You reported this less than 24h ago, I think we can survive a couple more hours until Marek and Matthias comment.
Comment 5 Marek Kašík 2012-09-06 08:53:52 UTC
Looking at my old files from the time I've been working on this, it seems that I copied the license from another source file from gnome-control-center (probably from um-password-dialog.c). I agree with relicensing of all files created by me for gnome-control-center to GPLv2.
Comment 6 Matthias Clasen 2012-09-06 11:53:07 UTC
Created attachment 223638 [details] [review]
switch all my files to gplv2+

Switching to GPLv2+ is fine with me. I've attached a patch that does it for all files with "Written by Matthias Clasen" in them. May want to check if somebody else has sufficient patches in them that warrants getting their ok.

There's um-realm-manager.[hc] in the user panel left, which was written by Stef Walter.
Comment 7 Marek Kašík 2012-09-06 13:57:32 UTC
Created attachment 223654 [details] [review]
Use GPLv2+ for files created by Marek Kasik

Hi,

this patch fixes the license for files in panels/printer/. These files were edited by Bastien, Matthias, Jiri Popelka, Robert Ancell, Stefano Facchini and me. I asked Jiri and he agrees with change. I've added Robert and Stefano to CC so they can tell us whether they agree or not.

Regards

Marek
Comment 8 Stefano Facchini 2012-09-06 21:22:17 UTC
(In reply to comment #7)
> Created an attachment (id=223654) [details] [review]
> Use GPLv2+ for files created by Marek Kasik
> 
> Hi,
> 
> this patch fixes the license for files in panels/printer/. These files were
> edited by Bastien, Matthias, Jiri Popelka, Robert Ancell, Stefano Facchini and
> me. I asked Jiri and he agrees with change. I've added Robert and Stefano to CC
> so they can tell us whether they agree or not.
> 
> Regards
> 
> Marek

My change was really trivial, but sure, switching to GPLv2+ is fine with me.
Comment 9 Matthias Clasen 2012-09-07 01:26:20 UTC
Oh, I pushed my patch by accident. Feel free to revert if somebody disagrees.
Comment 10 Robert Ancell 2012-09-10 21:08:52 UTC
No problems with GPL2+ from me.
Comment 11 Marek Kašík 2012-09-11 13:03:20 UTC
Comment on attachment 223654 [details] [review]
Use GPLv2+ for files created by Marek Kasik

I've pushed my patch to the master.
Comment 12 Bastien Nocera 2012-09-11 19:26:47 UTC
Stef, any problems with relicensing those few files to GPLv2+?
Comment 13 Stef Walter 2012-09-17 08:43:23 UTC
Created attachment 224481 [details] [review]
user-accounts: Relicense UmRealmManager to GPLv2+

 * And update the 'Written By' of UmRealmManager
Comment 14 Bastien Nocera 2012-09-17 12:09:19 UTC
Last relicense done, so closing. Won't be switching to GPLv3+ yet.

Attachment 224481 [details] pushed as 09e62d6 - user-accounts: Relicense UmRealmManager to GPLv2+